From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
qemu-riscv@nongnu.org
Subject: Re: [PATCH 7/8] target/helper: Remove unnecessary 'qemu/main-loop.h' header
Date: Mon, 28 Aug 2023 23:46:13 +0200 [thread overview]
Message-ID: <f2116163-bf23-0ab1-fd05-5489d6c579ed@linaro.org> (raw)
In-Reply-To: <ac9fafb6-a751-1503-a5c8-f71c9909a6e2@linaro.org>
On 28/8/23 23:45, Philippe Mathieu-Daudé wrote:
> On 28/8/23 20:40, Richard Henderson wrote:
>> On 8/28/23 07:55, Philippe Mathieu-Daudé wrote:
>>> "qemu/main-loop.h" declares functions related to QEMU's
>>> main loop mutex, which these files don't access. Remove
>>> the unused "qemu/main-loop.h" header.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>> target/riscv/pmu.h | 2 --
>>> target/xtensa/mmu_helper.c | 2 --
>>> target/xtensa/op_helper.c | 2 --
>>
>> At least these 3 files do two things.
>
> I can compile these files adding '#error' in "qemu/main-loop.h".
Doh now I got it, I also remove "exec/cpu_ldst.h". Probably
a failed rebase, sorry...
next prev parent reply other threads:[~2023-08-28 21:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 14:55 [PATCH 0/8] target/translate: Remove unused "exec/cpu_ldst.h" / "qemu/main-loop.h" Philippe Mathieu-Daudé
2023-08-28 14:55 ` [PATCH 1/8] target/ppc/pmu: Include missing 'qemu/timer.h' header Philippe Mathieu-Daudé
2023-08-28 14:55 ` [PATCH 2/8] target/riscv/pmu: Restrict 'qemu/log.h' include to source Philippe Mathieu-Daudé
2023-08-28 14:55 ` [PATCH 3/8] target/translate: Include missing 'exec/cpu_ldst.h' header Philippe Mathieu-Daudé
2023-08-28 18:35 ` Richard Henderson
2023-08-28 14:55 ` [PATCH 4/8] target/translate: Remove unnecessary " Philippe Mathieu-Daudé
2023-08-28 18:35 ` Richard Henderson
2023-08-28 14:55 ` [PATCH 5/8] target/translate: Restrict 'exec/cpu_ldst.h' to user emulation Philippe Mathieu-Daudé
2023-08-28 18:37 ` Richard Henderson
2023-08-28 14:55 ` [PATCH 6/8] target/helpers: Remove unnecessary 'exec/cpu_ldst.h' header Philippe Mathieu-Daudé
2023-08-28 18:37 ` Richard Henderson
2023-08-28 14:55 ` [PATCH 7/8] target/helper: Remove unnecessary 'qemu/main-loop.h' header Philippe Mathieu-Daudé
2023-08-28 18:40 ` Richard Henderson
2023-08-28 21:45 ` Philippe Mathieu-Daudé
2023-08-28 21:46 ` Philippe Mathieu-Daudé [this message]
2023-08-28 14:55 ` [PATCH 8/8] target/mips: Remove unused headers in lcsr_helper.c Philippe Mathieu-Daudé
2023-08-28 18:41 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2116163-bf23-0ab1-fd05-5489d6c579ed@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).