From: Richard Henderson <richard.henderson@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: qemu-devel@nongnu.org, iii@linux.ibm.com, laurent@vivier.eu
Subject: Re: linux-user: Add option to run `execve`d programs through QEMU
Date: Wed, 6 Nov 2024 09:38:55 +0000 [thread overview]
Message-ID: <f21fe153-6239-4c93-bf60-994976a9dbea@linaro.org> (raw)
In-Reply-To: <CAFUsyfKfM-X_qGN4Dy8DhES7zRi66s6yVZ3+_KmNM4f2GhBG+Q@mail.gmail.com>
On 11/5/24 23:54, Noah Goldstein wrote:
>>> You still need to handle is_proc_myself, for the guest binary.
>
> Would this by handled by basically do:
>
> ```
> if (is_proc_myself(p, "exe")) {
> exe = exec_path;
> if (through_qemu)
> argp[argp_offset] = exec_path;
> }
> ```
> Or am I missing something?
Something like that, yes.
>>> I wonder if those two cases are related. Do we need to also add an argument so that we
>>> can pass the executable to the next qemu via file descriptor? I.e. execvat becomes
>>>
>>> f = openat()
>>> execv(qemu, "-execfd", f)
>>>
>>> and is_proc_myself uses execfd, which we already have open.
>
> How does passing a fd from one process to another work?
As long as the fd is not marked O_CLOEXEC, it stays open in the new process. Providing
the number via command-line, or whatever, is sufficient for the new process to know what
is going on.
I now realize this is necessary for the AT_EMPTY_PATH flag, where we only have the file
descriptor.
r~
next prev parent reply other threads:[~2024-11-06 9:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 22:36 [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU Noah Goldstein
2024-08-30 22:37 ` Noah Goldstein
2024-09-10 22:06 ` Noah Goldstein
2024-09-24 14:43 ` Noah Goldstein
2024-10-02 8:08 ` Ilya Leoshkevich
2024-10-02 14:05 ` Noah Goldstein
2024-10-02 16:39 ` Ilya Leoshkevich
2024-10-02 16:42 ` Noah Goldstein
2024-10-11 18:14 ` Noah Goldstein
2024-10-22 22:06 ` Noah Goldstein
2024-10-29 14:51 ` Noah Goldstein
2024-10-02 14:08 ` Laurent Vivier
2024-10-02 14:25 ` Ilya Leoshkevich
2024-10-02 14:44 ` Noah Goldstein
2024-10-02 14:53 ` Ilya Leoshkevich
2024-10-02 15:10 ` Noah Goldstein
2024-10-02 16:14 ` Ilya Leoshkevich
2024-10-02 16:24 ` Noah Goldstein
2024-10-02 16:35 ` Ilya Leoshkevich
2024-10-02 16:36 ` Noah Goldstein
2024-10-02 15:59 ` Laurent Vivier
2024-10-02 14:50 ` [PATCH v2] " Noah Goldstein
2024-10-29 15:23 ` [PATCH v1] " Alex Bennée
2024-10-29 15:27 ` Noah Goldstein
2024-10-30 14:10 ` Noah Goldstein
2024-10-30 14:11 ` Noah Goldstein
2024-11-05 11:37 ` Richard Henderson
2024-11-05 23:48 ` Noah Goldstein
2024-11-05 23:54 ` Noah Goldstein
2024-11-06 9:38 ` Richard Henderson [this message]
2024-11-06 17:03 ` Noah Goldstein
2024-11-06 17:25 ` Richard Henderson
2024-11-06 17:53 ` Noah Goldstein
2024-11-06 18:13 ` Noah Goldstein
2024-11-06 21:10 ` Richard Henderson
2024-11-06 21:30 ` Noah Goldstein
2024-11-06 23:49 ` Noah Goldstein
2024-11-07 9:42 ` Richard Henderson
2024-11-07 9:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f21fe153-6239-4c93-bf60-994976a9dbea@linaro.org \
--to=richard.henderson@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).