* Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue [not found] <20170425131828.22480-1-n54@gmx.com> @ 2017-04-25 13:33 ` Peter Maydell 2017-04-25 13:50 ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski 2017-04-25 14:27 ` Laurent Vivier 2017-05-05 6:14 ` [Qemu-devel] " Michael Tokarev 1 sibling, 2 replies; 5+ messages in thread From: Peter Maydell @ 2017-04-25 13:33 UTC (permalink / raw) To: Kamil Rytarowski; +Cc: QEMU Trivial, QEMU Developers On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote: > Appease pkgsrc and use portable shell variable comparison. > This switches "==" to "=". It should not be a functional change. > > Signed-off-by: Kamil Rytarowski <n54@gmx.com> > --- Thanks for this patch; it's an easy bug to let slip in if your /bin/sh happens to be bash. PS: you forgot to cc qemu-devel@ on this patch. > scripts/qemu-binfmt-conf.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh > index 0f1aa63872..8afc3eb5bb 100755 > --- a/scripts/qemu-binfmt-conf.sh > +++ b/scripts/qemu-binfmt-conf.sh > @@ -284,12 +284,12 @@ while true ; do > shift > # check given cpu is in the supported CPU list > for cpu in ${qemu_target_list} ; do > - if [ "$cpu" == "$1" ] ; then > + if [ "$cpu" = "$1" ] ; then > break > fi > done > > - if [ "$cpu" == "$1" ] ; then > + if [ "$cpu" = "$1" ] ; then > qemu_target_list="$1" > else > echo "ERROR: unknown CPU \"$1\"" 1>&2 > -- > 2.12.2 Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue 2017-04-25 13:33 ` [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue Peter Maydell @ 2017-04-25 13:50 ` Kamil Rytarowski 2017-04-25 13:54 ` Eric Blake 2017-04-25 14:27 ` Laurent Vivier 1 sibling, 1 reply; 5+ messages in thread From: Kamil Rytarowski @ 2017-04-25 13:50 UTC (permalink / raw) To: Peter Maydell; +Cc: QEMU Trivial, QEMU Developers [-- Attachment #1: Type: text/plain, Size: 1490 bytes --] On 25.04.2017 15:33, Peter Maydell wrote: > On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote: >> Appease pkgsrc and use portable shell variable comparison. >> This switches "==" to "=". It should not be a functional change. >> >> Signed-off-by: Kamil Rytarowski <n54@gmx.com> >> --- > > Thanks for this patch; it's an easy bug to let slip in > if your /bin/sh happens to be bash. > > PS: you forgot to cc qemu-devel@ on this patch. > I assumed that qemu-trivial@ don't need to go to qemu-devel@. Thank you for pointing it out. >> scripts/qemu-binfmt-conf.sh | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh >> index 0f1aa63872..8afc3eb5bb 100755 >> --- a/scripts/qemu-binfmt-conf.sh >> +++ b/scripts/qemu-binfmt-conf.sh >> @@ -284,12 +284,12 @@ while true ; do >> shift >> # check given cpu is in the supported CPU list >> for cpu in ${qemu_target_list} ; do >> - if [ "$cpu" == "$1" ] ; then >> + if [ "$cpu" = "$1" ] ; then >> break >> fi >> done >> >> - if [ "$cpu" == "$1" ] ; then >> + if [ "$cpu" = "$1" ] ; then >> qemu_target_list="$1" >> else >> echo "ERROR: unknown CPU \"$1\"" 1>&2 >> -- >> 2.12.2 > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > thanks > -- PMM > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue 2017-04-25 13:50 ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski @ 2017-04-25 13:54 ` Eric Blake 0 siblings, 0 replies; 5+ messages in thread From: Eric Blake @ 2017-04-25 13:54 UTC (permalink / raw) To: Kamil Rytarowski, Peter Maydell; +Cc: QEMU Trivial, QEMU Developers [-- Attachment #1: Type: text/plain, Size: 1067 bytes --] On 04/25/2017 08:50 AM, Kamil Rytarowski wrote: > On 25.04.2017 15:33, Peter Maydell wrote: >> On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote: >>> Appease pkgsrc and use portable shell variable comparison. >>> This switches "==" to "=". It should not be a functional change. >>> >>> Signed-off-by: Kamil Rytarowski <n54@gmx.com> >>> --- >> >> Thanks for this patch; it's an easy bug to let slip in >> if your /bin/sh happens to be bash. >> >> PS: you forgot to cc qemu-devel@ on this patch. >> > > I assumed that qemu-trivial@ don't need to go to qemu-devel@. Thank you > for pointing it out. ALL patches need to go to qemu-devel (so we have a one-stop-shop for all pending patches), but some patches need to additionally go to secondary lists for catching the attention of the right maintainers. scripts/get_maintainer.pl is your friend, and it should always list qemu-devel in its answer. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue 2017-04-25 13:33 ` [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue Peter Maydell 2017-04-25 13:50 ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski @ 2017-04-25 14:27 ` Laurent Vivier 1 sibling, 0 replies; 5+ messages in thread From: Laurent Vivier @ 2017-04-25 14:27 UTC (permalink / raw) To: Peter Maydell, Kamil Rytarowski; +Cc: QEMU Trivial, QEMU Developers On 25/04/2017 15:33, Peter Maydell wrote: > On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote: >> Appease pkgsrc and use portable shell variable comparison. >> This switches "==" to "=". It should not be a functional change. >> >> Signed-off-by: Kamil Rytarowski <n54@gmx.com> >> --- > > Thanks for this patch; it's an easy bug to let slip in > if your /bin/sh happens to be bash. > > PS: you forgot to cc qemu-devel@ on this patch. > >> scripts/qemu-binfmt-conf.sh | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh >> index 0f1aa63872..8afc3eb5bb 100755 >> --- a/scripts/qemu-binfmt-conf.sh >> +++ b/scripts/qemu-binfmt-conf.sh >> @@ -284,12 +284,12 @@ while true ; do >> shift >> # check given cpu is in the supported CPU list >> for cpu in ${qemu_target_list} ; do >> - if [ "$cpu" == "$1" ] ; then >> + if [ "$cpu" = "$1" ] ; then >> break >> fi >> done >> >> - if [ "$cpu" == "$1" ] ; then >> + if [ "$cpu" = "$1" ] ; then >> qemu_target_list="$1" >> else >> echo "ERROR: unknown CPU \"$1\"" 1>&2 >> -- >> 2.12.2 > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Laurent Vivier <lvivier@redhat.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue [not found] <20170425131828.22480-1-n54@gmx.com> 2017-04-25 13:33 ` [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue Peter Maydell @ 2017-05-05 6:14 ` Michael Tokarev 1 sibling, 0 replies; 5+ messages in thread From: Michael Tokarev @ 2017-05-05 6:14 UTC (permalink / raw) To: Kamil Rytarowski, qemu-trivial; +Cc: peter.maydell, qemu-devel 25.04.2017 16:18, Kamil Rytarowski wrote: > Appease pkgsrc and use portable shell variable comparison. > This switches "==" to "=". It should not be a functional change. Applied to -trivial, thanks! /mjt > Signed-off-by: Kamil Rytarowski <n54@gmx.com> > --- > scripts/qemu-binfmt-conf.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh > index 0f1aa63872..8afc3eb5bb 100755 > --- a/scripts/qemu-binfmt-conf.sh > +++ b/scripts/qemu-binfmt-conf.sh > @@ -284,12 +284,12 @@ while true ; do > shift > # check given cpu is in the supported CPU list > for cpu in ${qemu_target_list} ; do > - if [ "$cpu" == "$1" ] ; then > + if [ "$cpu" = "$1" ] ; then > break > fi > done > > - if [ "$cpu" == "$1" ] ; then > + if [ "$cpu" = "$1" ] ; then > qemu_target_list="$1" > else > echo "ERROR: unknown CPU \"$1\"" 1>&2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-05 6:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170425131828.22480-1-n54@gmx.com>
2017-04-25 13:33 ` [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue Peter Maydell
2017-04-25 13:50 ` [Qemu-devel] [Qemu-trivial] " Kamil Rytarowski
2017-04-25 13:54 ` Eric Blake
2017-04-25 14:27 ` Laurent Vivier
2017-05-05 6:14 ` [Qemu-devel] " Michael Tokarev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).