From: Feng Jiang <jiangfeng@kylinos.cn>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: i.mitsyanko@gmail.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] exynos: Fix out-of-bounds access in exynos4210_gcomp_find
Date: Fri, 14 Apr 2023 09:11:39 +0800 [thread overview]
Message-ID: <f23651dabdba5c02f44c5d3f9fe90c2db2483284.camel@kylinos.cn> (raw)
In-Reply-To: <CAFEAcA_VP-Y2x9efKW8atddUL64D03eSE8A7h3hk8N7s9spMhg@mail.gmail.com>
On Tue, 2023-04-11 at 14:02 +0100, Peter Maydell wrote:
> On Tue, 4 Apr 2023 at 08:45, Feng Jiang <jiangfeng@kylinos.cn> wrote:
> >
> > When 'res' equals -1, the array 's->g_timer.reg.comp[]' is accessed
> > out of bounds.
> >
> > Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
> > ---
> > hw/timer/exynos4210_mct.c | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
>
> Only happens if you change the source code to enable the debug
> printfs though, which isn't the default. I'll tweak the
> commit message to make that clearer.
>
> Applied to target-arm.next for 8.1, thanks.
>
> -- PMM
>
Hi Peter, Thanks very much for your review!
Next time I will write the commit message more clearly and in detail.
Best regards,
Feng
prev parent reply other threads:[~2023-04-14 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 7:45 [PATCH] exynos: Fix out-of-bounds access in exynos4210_gcomp_find Feng Jiang
2023-04-11 13:02 ` Peter Maydell
2023-04-14 1:11 ` Feng Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23651dabdba5c02f44c5d3f9fe90c2db2483284.camel@kylinos.cn \
--to=jiangfeng@kylinos.cn \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).