From: Richard Henderson <richard.henderson@linaro.org>
To: Vineet Gupta <vineetg@rivosinc.com>, qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@wdc.com>,
Edwin Lu <ewlu@rivosinc.com>,
gnu-toolchain <gnu-toolchain@rivosinc.com>
Subject: Re: [PATCH 1/2] linux-user/riscv: vdso: fix call frame info in __vdso_rt_sigreturn
Date: Tue, 16 Jan 2024 10:18:46 +1100 [thread overview]
Message-ID: <f23eb285-16a8-44ee-991b-224b480dd91b@linaro.org> (raw)
In-Reply-To: <20240115231552.3217789-1-vineetg@rivosinc.com>
On 1/16/24 10:15, Vineet Gupta wrote:
> When testing gcc testsuite against QEMU v8.2 we found some additional
> failures vs. v8.1.2.
>
> | FAIL: gcc.dg/cleanup-10.c execution test
> | FAIL: gcc.dg/cleanup-11.c execution test
> | FAIL: gcc.dg/cleanup-8.c execution test
> | FAIL: gcc.dg/cleanup-9.c execution test
>
> All of these tests involve unwinding off signal stack and v8.2 did
> introduce a vdso with sigreturn trampoline and associated unwinding
> info. It seems that info is not correct and making it similar to
> to one in the linux kernel fixes the above failures.
So.. you didn't actually determine what might be off in the unwind info?
> + .cfi_startproc
> + .cfi_signal_frame
> + raw_syscall __NR_rt_sigreturn
> + .cfi_endproc
No, this is wrong. It indicates that the unwind info is present and trivial.
r~
next prev parent reply other threads:[~2024-01-15 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 23:15 [PATCH 1/2] linux-user/riscv: vdso: fix call frame info in __vdso_rt_sigreturn Vineet Gupta
2024-01-15 23:15 ` [PATCH 2/2] linux-user/riscv: rebuild vdso binaries after prev fix Vineet Gupta
2024-01-15 23:18 ` Richard Henderson [this message]
2024-01-16 23:52 ` [PATCH 1/2] linux-user/riscv: vdso: fix call frame info in __vdso_rt_sigreturn Vineet Gupta
2024-01-17 0:24 ` Richard Henderson
2024-01-18 8:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23eb285-16a8-44ee-991b-224b480dd91b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=ewlu@rivosinc.com \
--cc=gnu-toolchain@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).