From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: berrange@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
Jintao Yin <nicememory@gmail.com>
Subject: Re: [PATCH] ui/spice: fix compilation on win32
Date: Wed, 22 Mar 2023 12:03:37 +0100 [thread overview]
Message-ID: <f23faa51-0e21-2072-6cc6-08be8ad99492@linaro.org> (raw)
In-Reply-To: <20230322075256.2043812-1-marcandre.lureau@redhat.com>
On 22/3/23 08:52, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> qemu_close_to_socket() renaming left-over.
>
> Fixes:
> https://gitlab.com/qemu-project/qemu/-/issues/1553
>
Reported-by: Jintao Yin <nicememory@gmail.com>
> Fixes: commit e40283d9a ("ui/spice: fix SOCKET handling regression")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/spice-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 67cfd3ca9c..52a59386d7 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -149,7 +149,7 @@ static void watch_remove(SpiceWatch *watch)
> qemu_set_fd_handler(watch->fd, NULL, NULL, NULL);
> #ifdef WIN32
> /* SOCKET is owned by spice */
> - qemu_close_to_socket(watch->fd);
> + qemu_close_socket_osfhandle(watch->fd);
> #endif
> g_free(watch);
> }
next prev parent reply other threads:[~2023-03-22 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 7:52 [PATCH] ui/spice: fix compilation on win32 marcandre.lureau
2023-03-22 8:44 ` Philippe Mathieu-Daudé
2023-03-22 9:00 ` Philippe Mathieu-Daudé
2023-03-22 10:22 ` Marc-André Lureau
2023-03-22 10:57 ` Philippe Mathieu-Daudé
2023-03-22 11:03 ` Philippe Mathieu-Daudé [this message]
2023-03-24 10:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23faa51-0e21-2072-6cc6-08be8ad99492@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=nicememory@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).