From: G 3 <programmingkidx@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cocoa.m issues fixed
Date: Sun, 21 Jun 2009 10:06:13 -0400 [thread overview]
Message-ID: <f2501d88dd652bd9df9dc16cbae3cee5@gmail.com> (raw)
In-Reply-To: <61E57A9F-6D9A-4DF3-9CE6-0B8056DD1C60@web.de>
On Jun 21, 2009, at 6:10 AM, Andreas Färber wrote:
>
> Am 21.06.2009 um 03:19 schrieb G 3:
>
>> +int cocoa_keycode_to_qemu(int keycode);
>> +
>
> This seems unrelated. I believe you're trying to suppress a warning
> I've been seeing on 10.5 as well - if so, please provide that as a
> separate patch with appropriate description.
>
This function prototype would eliminate this warning:
cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu'
Why a separate patch. Why not kill two birds with one stone?
>> + char bin[5] = "qemu";
>
> What warning/error does this solve?
This is the warning that this change resolves:
cocoa.m:786: warning: initialization discards qualifiers from pointer
target type
next prev parent reply other threads:[~2009-06-21 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 1:19 [Qemu-devel] [PATCH] cocoa.m issues fixed G 3
2009-06-21 10:10 ` Andreas Färber
2009-06-21 14:06 ` G 3 [this message]
2009-06-21 15:23 ` Avi Kivity
2009-06-21 18:07 ` Blue Swirl
2009-06-21 18:16 ` Avi Kivity
2009-06-22 17:05 ` Stuart Brady
2009-06-22 17:35 ` Blue Swirl
2009-06-22 18:47 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2501d88dd652bd9df9dc16cbae3cee5@gmail.com \
--to=programmingkidx@gmail.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).