From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MINgc-0005cM-Au for qemu-devel@nongnu.org; Sun, 21 Jun 2009 10:06:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MINgY-0005YV-Sg for qemu-devel@nongnu.org; Sun, 21 Jun 2009 10:06:22 -0400 Received: from [199.232.76.173] (port=54663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MINgY-0005YK-Q2 for qemu-devel@nongnu.org; Sun, 21 Jun 2009 10:06:18 -0400 Received: from mail-gx0-f207.google.com ([209.85.217.207]:55807) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MINgY-0003iS-DM for qemu-devel@nongnu.org; Sun, 21 Jun 2009 10:06:18 -0400 Received: by gxk3 with SMTP id 3so11431861gxk.10 for ; Sun, 21 Jun 2009 07:06:16 -0700 (PDT) In-Reply-To: <61E57A9F-6D9A-4DF3-9CE6-0B8056DD1C60@web.de> References: <61E57A9F-6D9A-4DF3-9CE6-0B8056DD1C60@web.de> Mime-Version: 1.0 (Apple Message framework v624) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Message-Id: Content-Transfer-Encoding: quoted-printable From: G 3 Subject: Re: [Qemu-devel] [PATCH] cocoa.m issues fixed Date: Sun, 21 Jun 2009 10:06:13 -0400 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org On Jun 21, 2009, at 6:10 AM, Andreas F=E4rber wrote: > > Am 21.06.2009 um 03:19 schrieb G 3: > >> +int cocoa_keycode_to_qemu(int keycode); >> + > > This seems unrelated. I believe you're trying to suppress a warning=20 > I've been seeing on 10.5 as well - if so, please provide that as a=20 > separate patch with appropriate description. > This function prototype would eliminate this warning: cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu' Why a separate patch. Why not kill two birds with one stone? >> + char bin[5] =3D "qemu"; > > What warning/error does this solve? This is the warning that this change resolves: cocoa.m:786: warning: initialization discards qualifiers from pointer=20 target type=