From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message
Date: Fri, 7 Jul 2023 04:19:35 -0300 [thread overview]
Message-ID: <f25113e7-b23d-ebd8-03c3-c5dc9db6e524@gmail.com> (raw)
In-Reply-To: <20230706024528.40065-1-joel@jms.id.au>
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 7/5/23 23:45, Joel Stanley wrote:
> Add the function name so there's an indication as to where the message
> is coming from. Change all prints to use the offset instead of the
> address.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Happy to use the address instead of the offset (or print both), but I
> like the idea of being consistent.
> ---
> hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index ffbc29cbf4f9..3eb95670d6a3 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -85,8 +85,8 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> val = 0x24f000000000000ull;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -95,8 +95,10 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> static void pnv_core_power8_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> unsigned int width)
> {
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + uint32_t offset = addr >> 3;
> +
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
>
> static const MemoryRegionOps pnv_core_power8_xscom_ops = {
> @@ -140,8 +142,8 @@ static uint64_t pnv_core_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -157,8 +159,8 @@ static void pnv_core_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -189,8 +191,8 @@ static uint64_t pnv_core_power10_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -203,8 +205,8 @@ static void pnv_core_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -421,7 +423,7 @@ static uint64_t pnv_quad_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -438,7 +440,7 @@ static void pnv_quad_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case P9X_EX_NCU_SPEC_BAR + 0x400: /* Second EX */
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
> @@ -465,7 +467,7 @@ static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -479,7 +481,7 @@ static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
prev parent reply other threads:[~2023-07-07 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
2023-07-06 8:55 ` Philippe Mathieu-Daudé
2023-07-07 7:19 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25113e7-b23d-ebd8-03c3-c5dc9db6e524@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).