* [PATCH] ppc/pnv: Log all unimp warnings with similar message
@ 2023-07-06 2:45 Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Joel Stanley @ 2023-07-06 2:45 UTC (permalink / raw)
To: Cédric Le Goater, Nicholas Piggin, Frédéric Barrat
Cc: qemu-devel, qemu-ppc
Add the function name so there's an indication as to where the message
is coming from. Change all prints to use the offset instead of the
address.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Happy to use the address instead of the offset (or print both), but I
like the idea of being consistent.
---
hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
index ffbc29cbf4f9..3eb95670d6a3 100644
--- a/hw/ppc/pnv_core.c
+++ b/hw/ppc/pnv_core.c
@@ -85,8 +85,8 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
val = 0x24f000000000000ull;
break;
default:
- qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
- addr);
+ qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
+ offset);
}
return val;
@@ -95,8 +95,10 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
static void pnv_core_power8_xscom_write(void *opaque, hwaddr addr, uint64_t val,
unsigned int width)
{
- qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
- addr);
+ uint32_t offset = addr >> 3;
+
+ qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
+ offset);
}
static const MemoryRegionOps pnv_core_power8_xscom_ops = {
@@ -140,8 +142,8 @@ static uint64_t pnv_core_power9_xscom_read(void *opaque, hwaddr addr,
val = 0;
break;
default:
- qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
- addr);
+ qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
+ offset);
}
return val;
@@ -157,8 +159,8 @@ static void pnv_core_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
break;
default:
- qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
- addr);
+ qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
+ offset);
}
}
@@ -189,8 +191,8 @@ static uint64_t pnv_core_power10_xscom_read(void *opaque, hwaddr addr,
val = 0;
break;
default:
- qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
- addr);
+ qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
+ offset);
}
return val;
@@ -203,8 +205,8 @@ static void pnv_core_power10_xscom_write(void *opaque, hwaddr addr,
switch (offset) {
default:
- qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
- addr);
+ qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
+ offset);
}
}
@@ -421,7 +423,7 @@ static uint64_t pnv_quad_power9_xscom_read(void *opaque, hwaddr addr,
val = 0;
break;
default:
- qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
+ qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
offset);
}
@@ -438,7 +440,7 @@ static void pnv_quad_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
case P9X_EX_NCU_SPEC_BAR + 0x400: /* Second EX */
break;
default:
- qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
+ qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
offset);
}
}
@@ -465,7 +467,7 @@ static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
switch (offset) {
default:
- qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
+ qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
offset);
}
@@ -479,7 +481,7 @@ static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr,
switch (offset) {
default:
- qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
+ qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
offset);
}
}
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
@ 2023-07-06 6:22 ` Cédric Le Goater
2023-07-06 8:55 ` Philippe Mathieu-Daudé
2023-07-07 7:19 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2023-07-06 6:22 UTC (permalink / raw)
To: Joel Stanley, Nicholas Piggin, Frédéric Barrat
Cc: qemu-devel, qemu-ppc
On 7/6/23 04:45, Joel Stanley wrote:
> Add the function name so there's an indication as to where the message
> is coming from. Change all prints to use the offset instead of the
> address.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> Happy to use the address instead of the offset (or print both), but I
> like the idea of being consistent.
> ---
> hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index ffbc29cbf4f9..3eb95670d6a3 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -85,8 +85,8 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> val = 0x24f000000000000ull;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -95,8 +95,10 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> static void pnv_core_power8_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> unsigned int width)
> {
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + uint32_t offset = addr >> 3;
> +
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
>
> static const MemoryRegionOps pnv_core_power8_xscom_ops = {
> @@ -140,8 +142,8 @@ static uint64_t pnv_core_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -157,8 +159,8 @@ static void pnv_core_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -189,8 +191,8 @@ static uint64_t pnv_core_power10_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -203,8 +205,8 @@ static void pnv_core_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -421,7 +423,7 @@ static uint64_t pnv_quad_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -438,7 +440,7 @@ static void pnv_quad_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case P9X_EX_NCU_SPEC_BAR + 0x400: /* Second EX */
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
> @@ -465,7 +467,7 @@ static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -479,7 +481,7 @@ static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
@ 2023-07-06 8:55 ` Philippe Mathieu-Daudé
2023-07-07 7:19 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-07-06 8:55 UTC (permalink / raw)
To: Joel Stanley, Cédric Le Goater, Nicholas Piggin,
Frédéric Barrat
Cc: qemu-devel, qemu-ppc
On 6/7/23 04:45, Joel Stanley wrote:
> Add the function name so there's an indication as to where the message
> is coming from. Change all prints to use the offset instead of the
> address.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Happy to use the address instead of the offset (or print both), but I
> like the idea of being consistent.
> ---
> hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
2023-07-06 8:55 ` Philippe Mathieu-Daudé
@ 2023-07-07 7:19 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2023-07-07 7:19 UTC (permalink / raw)
To: Joel Stanley, Cédric Le Goater, Nicholas Piggin,
Frédéric Barrat
Cc: qemu-devel, qemu-ppc
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 7/5/23 23:45, Joel Stanley wrote:
> Add the function name so there's an indication as to where the message
> is coming from. Change all prints to use the offset instead of the
> address.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Happy to use the address instead of the offset (or print both), but I
> like the idea of being consistent.
> ---
> hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index ffbc29cbf4f9..3eb95670d6a3 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -85,8 +85,8 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> val = 0x24f000000000000ull;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -95,8 +95,10 @@ static uint64_t pnv_core_power8_xscom_read(void *opaque, hwaddr addr,
> static void pnv_core_power8_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> unsigned int width)
> {
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + uint32_t offset = addr >> 3;
> +
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
>
> static const MemoryRegionOps pnv_core_power8_xscom_ops = {
> @@ -140,8 +142,8 @@ static uint64_t pnv_core_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -157,8 +159,8 @@ static void pnv_core_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case PNV9_XSCOM_EC_PPM_SPECIAL_WKUP_OTR:
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -189,8 +191,8 @@ static uint64_t pnv_core_power10_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> + offset);
> }
>
> return val;
> @@ -203,8 +205,8 @@ static void pnv_core_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=0x%" HWADDR_PRIx "\n",
> - addr);
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> + offset);
> }
> }
>
> @@ -421,7 +423,7 @@ static uint64_t pnv_quad_power9_xscom_read(void *opaque, hwaddr addr,
> val = 0;
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -438,7 +440,7 @@ static void pnv_quad_power9_xscom_write(void *opaque, hwaddr addr, uint64_t val,
> case P9X_EX_NCU_SPEC_BAR + 0x400: /* Second EX */
> break;
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
> @@ -465,7 +467,7 @@ static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: reading @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp read 0x%08x\n", __func__,
> offset);
> }
>
> @@ -479,7 +481,7 @@ static void pnv_quad_power10_xscom_write(void *opaque, hwaddr addr,
>
> switch (offset) {
> default:
> - qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,
> + qemu_log_mask(LOG_UNIMP, "%s: unimp write 0x%08x\n", __func__,
> offset);
> }
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-07 7:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
2023-07-06 8:55 ` Philippe Mathieu-Daudé
2023-07-07 7:19 ` Daniel Henrique Barboza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).