From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, mark.cave-ayland@ilande.co.uk,
berrange@redhat.com, philmd@linaro.org
Subject: Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak
Date: Mon, 3 Feb 2025 18:39:47 +0100 [thread overview]
Message-ID: <f259ce9d-8488-4dd8-88bc-587c858c4448@redhat.com> (raw)
In-Reply-To: <54d4e11f-75ea-42d7-9d53-0c7d4eb4b239@linaro.org>
On 03/02/2025 17.49, Richard Henderson wrote:
> On 2/3/25 02:39, Thomas Huth wrote:
>> [...]> diff --git a/configs/targets/hppa-linux-user.mak b/configs/targets/
>> hppa-linux-user.mak
>>> index 8e0a80492f..4295cf384e 100644
>>> --- a/configs/targets/hppa-linux-user.mak
>>> +++ b/configs/targets/hppa-linux-user.mak
>>> @@ -3,3 +3,5 @@ TARGET_ABI32=y
>>> TARGET_SYSTBL_ABI=common,32
>>> TARGET_SYSTBL=syscall.tbl
>>> TARGET_BIG_ENDIAN=y
>>> +# Compromise to ease maintainence vs system mode
>>
>> s/maintainence/maintenance/
>
> Oops.
>
>>
>>> diff --git a/configs/targets/mipsn32-linux-user.mak b/configs/targets/
>>> mipsn32-linux- user.mak
>>> index 206095da64..39ae214633 100644
>>> --- a/configs/targets/mipsn32-linux-user.mak
>>> +++ b/configs/targets/mipsn32-linux-user.mak
>>> @@ -5,3 +5,4 @@ TARGET_BASE_ARCH=mips
>>> TARGET_SYSTBL_ABI=n32
>>> TARGET_SYSTBL=syscall_n32.tbl
>>> TARGET_BIG_ENDIAN=y
>>> +TARGET_LONG_BITS=64
>>
>> Why is this 64 ?
>>
>>> diff --git a/configs/targets/mipsn32el-linux-user.mak b/configs/targets/
>>> mipsn32el-linux- user.mak
>>> index ca2a3ed753..d9b61d6990 100644
>>> --- a/configs/targets/mipsn32el-linux-user.mak
>>> +++ b/configs/targets/mipsn32el-linux-user.mak
>>> @@ -4,3 +4,4 @@ TARGET_ABI32=y
>>> TARGET_BASE_ARCH=mips
>>> TARGET_SYSTBL_ABI=n32
>>> TARGET_SYSTBL=syscall_n32.tbl
>>> +TARGET_LONG_BITS=64
>>
>> dito?
>>
>>> diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/
>>> targets/sparc32plus- linux-user.mak
>>> index 6cc8fa516b..7a16934fd1 100644
>>> --- a/configs/targets/sparc32plus-linux-user.mak
>>> +++ b/configs/targets/sparc32plus-linux-user.mak
>>> @@ -5,3 +5,4 @@ TARGET_ABI_DIR=sparc
>>> TARGET_SYSTBL_ABI=common,32
>>> TARGET_SYSTBL=syscall.tbl
>>> TARGET_BIG_ENDIAN=y
>>> +TARGET_LONG_BITS=64
>>
>> Same question here: Why 64? If this isn't a mistake, could you maybe add a
>> comment?
>
> All three are 64-bit cpus using an ABI with 32-bit pointers.
Ok, thanks, makes sense now. So with the typo fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-02-03 17:40 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 3:18 [PATCH v2 00/14] meson: Deprecate 32-bit host support Richard Henderson
2025-02-03 3:18 ` [PATCH v2 01/14] meson: Drop tcg as a module Richard Henderson
2025-02-03 9:58 ` Thomas Huth
2025-02-03 18:39 ` Philippe Mathieu-Daudé
2025-02-03 11:34 ` Alex Bennée
2025-02-03 18:36 ` Philippe Mathieu-Daudé
2025-02-03 3:18 ` [PATCH v2 02/14] tcg: Move stubs in tcg/perf.h to tcg/perf-stubs.c Richard Henderson
2025-02-03 10:00 ` Thomas Huth
2025-02-03 11:34 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 03/14] plugins: Uninline qemu_plugin_add_opts Richard Henderson
2025-02-03 10:02 ` Thomas Huth
2025-02-03 11:44 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 04/14] meson: Introduce CONFIG_TCG_TARGET Richard Henderson
2025-02-03 10:08 ` Thomas Huth
2025-02-03 16:38 ` Richard Henderson
2025-02-04 6:41 ` Thomas Huth
2025-02-03 3:18 ` [PATCH v2 05/14] tcg: Link only when required in system mode Richard Henderson
2025-02-03 10:15 ` Thomas Huth
2025-02-03 11:48 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 06/14] plugins: " Richard Henderson
2025-02-03 10:16 ` Thomas Huth
2025-02-03 11:49 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 07/14] accel/stubs: Expand stubs for TCG Richard Henderson
2025-02-03 10:22 ` Thomas Huth
2025-02-03 16:43 ` Richard Henderson
2025-02-03 17:38 ` Thomas Huth
2025-02-03 20:00 ` Richard Henderson
2025-02-03 3:18 ` [PATCH v2 08/14] target/mips: Protect objects with CONFIG_TCG Richard Henderson
2025-02-03 10:24 ` Thomas Huth
2025-02-03 17:25 ` Philippe Mathieu-Daudé
2025-02-03 18:01 ` Richard Henderson
2025-02-03 3:18 ` [PATCH v2 09/14] gitlab: Replace aarch64 with arm in cross-i686-tci build Richard Henderson
2025-02-03 10:30 ` Thomas Huth
2025-02-03 12:31 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak Richard Henderson
2025-02-03 10:39 ` Thomas Huth
2025-02-03 12:33 ` Alex Bennée
2025-02-03 16:49 ` Richard Henderson
2025-02-03 17:39 ` Thomas Huth [this message]
2025-02-03 17:48 ` Philippe Mathieu-Daudé
2025-02-03 18:30 ` Philippe Mathieu-Daudé
2025-02-03 19:19 ` Richard Henderson
2025-02-03 3:18 ` [PATCH v2 11/14] target/*: Remove TARGET_LONG_BITS from cpu-param.h Richard Henderson
2025-02-03 10:43 ` Thomas Huth
2025-02-03 12:34 ` Alex Bennée
2025-02-03 18:31 ` Philippe Mathieu-Daudé
2025-02-03 3:18 ` [PATCH v2 12/14] meson: Disallow 64-bit on 32-bit TCG emulation Richard Henderson
2025-02-03 10:46 ` Thomas Huth
2025-02-03 13:54 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 13/14] meson: Deprecate 32-bit host support Richard Henderson
2025-02-03 10:47 ` Thomas Huth
2025-02-03 13:56 ` Alex Bennée
2025-02-03 3:18 ` [PATCH v2 14/14] tcg: Remove TCG_OVERSIZED_GUEST Richard Henderson
2025-02-03 13:59 ` Alex Bennée
2025-02-04 17:42 ` Richard Henderson
2025-02-03 12:54 ` [PATCH v2 00/14] meson: Deprecate 32-bit host support Paolo Bonzini
2025-02-03 21:55 ` Richard Henderson
2025-02-03 22:43 ` Stefano Stabellini
2025-02-04 8:12 ` Daniel P. Berrangé
2025-02-04 8:19 ` Juergen Gross
2025-02-04 9:11 ` Jan Beulich
2025-02-04 10:44 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f259ce9d-8488-4dd8-88bc-587c858c4448@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).