From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Fam Zheng" <fam@euphon.net>,
"Julia Suvorova" <jusual@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Coiby Xu" <Coiby.Xu@gmail.com>, "Paul Durrant" <paul@xen.org>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Juan Quintela" <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Peter Lieven" <pl@kamp.de>,
eesposit@redhat.com, "Aarushi Mehta" <mehta.aaru20@gmail.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Xie Yongji" <xieyongji@bytedance.com>,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v2 05/16] util/vhost-user-server: rename refcount to in_flight counter
Date: Thu, 20 Apr 2023 10:18:45 +0200 [thread overview]
Message-ID: <f25c43d7-2924-b739-ec65-a10523d4e566@linaro.org> (raw)
In-Reply-To: <20230419172817.272758-6-stefanha@redhat.com>
On 19/4/23 19:28, Stefan Hajnoczi wrote:
> The VuServer object has a refcount field and ref/unref APIs. The name is
> confusing because it's actually an in-flight request counter instead of
> a refcount.
>
> Normally a refcount destroys the object upon reaching zero. The VuServer
> counter is used to wake up the vhost-user coroutine when there are no
> more requests.
>
> Avoid confusing by renaming refcount and ref/unref to in_flight and
> inc/dec.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> include/qemu/vhost-user-server.h | 6 +++---
> block/export/vhost-user-blk-server.c | 11 +++++++----
> util/vhost-user-server.c | 14 +++++++-------
> 3 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-04-20 8:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 17:28 [PATCH v2 00/16] block: remove aio_disable_external() API Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 01/16] hw/qdev: introduce qdev_is_realized() helper Stefan Hajnoczi
2023-04-20 8:17 ` Philippe Mathieu-Daudé
2023-04-19 17:28 ` [PATCH v2 02/16] virtio-scsi: avoid race between unplug and transport event Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 03/16] virtio-scsi: stop using aio_disable_external() during unplug Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 04/16] block/export: only acquire AioContext once for vhost_user_server_stop() Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 05/16] util/vhost-user-server: rename refcount to in_flight counter Stefan Hajnoczi
2023-04-20 8:18 ` Philippe Mathieu-Daudé [this message]
2023-04-19 17:28 ` [PATCH v2 06/16] block/export: wait for vhost-user-blk requests when draining Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 07/16] block/export: stop using is_external in vhost-user-blk server Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 08/16] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore Stefan Hajnoczi
2023-04-20 7:54 ` Paul Durrant
2023-04-19 17:28 ` [PATCH v2 09/16] block: add blk_in_drain() API Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 10/16] block: drain from main loop thread in bdrv_co_yield_to_drain() Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 11/16] xen-block: implement BlockDevOps->drained_begin() Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 12/16] hw/xen: do not set is_external=true on evtchn fds Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 13/16] block/export: rewrite vduse-blk drain code Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 14/16] block/export: don't require AioContext lock around blk_exp_ref/unref() Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 15/16] block/fuse: do not set is_external=true on FUSE fd Stefan Hajnoczi
2023-04-19 17:28 ` [PATCH v2 16/16] virtio: make it possible to detach host notifier from any thread Stefan Hajnoczi
2023-04-19 18:51 ` Eric Blake
2023-04-20 11:29 ` Stefan Hajnoczi
2023-04-20 12:20 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25c43d7-2924-b739-ec65-a10523d4e566@linaro.org \
--to=philmd@linaro.org \
--cc=Coiby.Xu@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=eesposit@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jusual@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mehta.aaru20@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=sgarzare@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).