qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	qemu-ppc@nongnu.org,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 9/9] target/ppc: Fix timer register accessors when !KVM
Date: Tue, 20 Jun 2023 11:10:15 +0200	[thread overview]
Message-ID: <f2731268-004f-74c4-3aa9-24dc0bacf835@linaro.org> (raw)
In-Reply-To: <20230620055911.187065-10-clg@kaod.org>

On 6/20/23 07:59, Cédric Le Goater wrote:
> When the Timer Control and Timer Status registers are modified, avoid
> calling the KVM backend when not available
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   target/ppc/kvm.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index a7f2de9d1018..a8a935e26726 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -1728,6 +1728,10 @@ int kvmppc_or_tsr_bits(PowerPCCPU *cpu, uint32_t tsr_bits)
>           .addr = (uintptr_t) &bits,
>       };
>   
> +    if (!kvm_enabled()) {
> +        return 0;
> +    }

assert(kvm_enabled()) ?


r~


  reply	other threads:[~2023-06-20  9:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  5:59 [PATCH 0/9] ppc: New reviewers and KVM cleanups Cédric Le Goater
2023-06-20  5:59 ` [PATCH 1/9] MAINTAINERS: Add reviewers for PowerNV baremetal emulation Cédric Le Goater
2023-06-20  7:11   ` Frederic Barrat
2023-06-20  9:11   ` Richard Henderson
2023-06-20  9:40   ` Nicholas Piggin
2023-06-20  5:59 ` [PATCH 2/9] MAINTAINERS: Add reviewer for PowerPC TCG CPUs Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  9:40   ` Nicholas Piggin
2023-06-20 10:18   ` Philippe Mathieu-Daudé
2023-06-20  5:59 ` [PATCH 3/9] MAINTAINERS: Add reviewer for XIVE Cédric Le Goater
2023-06-20  7:11   ` Frederic Barrat
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 4/9] ppc/prep: Report an error when run with KVM Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 5/9] ppc/pegasos2: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20 10:41   ` BALATON Zoltan
2023-06-20  5:59 ` [PATCH 6/9] ppc/sam460ex: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20 10:42   ` BALATON Zoltan
2023-06-20 10:52     ` Cédric Le Goater
2023-06-20 10:56       ` BALATON Zoltan
2023-06-20  5:59 ` [PATCH 7/9] ppc/bamboo: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 8/9] ppc/pnv: Rephrase " Cédric Le Goater
2023-06-20  9:12   ` Richard Henderson
2023-06-20 11:31   ` Philippe Mathieu-Daudé
2023-06-20 11:38     ` [SPAM] " Cédric Le Goater
2023-06-20  5:59 ` [PATCH 9/9] target/ppc: Fix timer register accessors when !KVM Cédric Le Goater
2023-06-20  9:10   ` Richard Henderson [this message]
2023-06-20 11:53     ` Cédric Le Goater
2023-06-23  9:29 ` [PATCH 0/9] ppc: New reviewers and KVM cleanups Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2731268-004f-74c4-3aa9-24dc0bacf835@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).