From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0Myg-0002AE-Sn for qemu-devel@nongnu.org; Tue, 20 Oct 2009 18:14:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0Myc-00029l-DA for qemu-devel@nongnu.org; Tue, 20 Oct 2009 18:14:50 -0400 Received: from [199.232.76.173] (port=55582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0Myc-00029i-A0 for qemu-devel@nongnu.org; Tue, 20 Oct 2009 18:14:46 -0400 Received: from mail-pz0-f188.google.com ([209.85.222.188]:38099) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0Myc-0006PA-0R for qemu-devel@nongnu.org; Tue, 20 Oct 2009 18:14:46 -0400 Received: by pzk26 with SMTP id 26so4397883pzk.4 for ; Tue, 20 Oct 2009 15:14:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20091020170800.GG32538@redhat.com> References: <4ADCE635.4060604@codemonkey.ws> <4ADD9388.8040206@redhat.com> <20091020170800.GG32538@redhat.com> From: Mulyadi Santosa Date: Wed, 21 Oct 2009 05:14:25 +0700 Message-ID: Subject: Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi... On Wed, Oct 21, 2009 at 12:08 AM, Daniel P. Berrange wrote: > The problem with adding lots of magic key-sequences, is that the more > you add, the more likely they are to clash with something that the > guest OS wants to use. You may make this use case work, but break > someone else's use case. Thus, IMHO, magic key sequences should be kept > to the bare minimum neccessary to access functionality for which there > is no other viable access method. Thanks for the insights from all of you. The rule "to keep the magic keys at the bare minimum" is something I fairly agree. So probably in maintenance and development robustness's point of view, this patch should just live outside of main tree... well unless there are lot of supporter -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogspot.com training: mulyaditraining.blogspot.com