From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E6BC433E0 for ; Tue, 28 Jul 2020 14:51:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC26206D8 for ; Tue, 28 Jul 2020 14:51:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sa1961Sf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CC26206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0Qx3-0004QJ-TB for qemu-devel@archiver.kernel.org; Tue, 28 Jul 2020 10:51:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0QwK-0003Xw-RL for qemu-devel@nongnu.org; Tue, 28 Jul 2020 10:50:48 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55567 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0QwI-0004CD-7V for qemu-devel@nongnu.org; Tue, 28 Jul 2020 10:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595947845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JMgFavHQqzhzqOkbZXmciJzGK84BP1/DCGMHs/TSk2w=; b=Sa1961Sf7Sv0gyZ8CKqf9Sh9XBdXiCksJ3WvqEWdGs+gJ/Bhd14K9JGn5cR9EnzYqK+Ym/ Fi4fy/ELyB4tHLbrxBxlQu3VzfD4zNfr4bmc901b1GBlfY6VT6xvqJgS7Se9jIyW90UTGg gq5IZnXKZfl8TmcQs03YprK3VJj2bes= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-OJUGkaLdOH-cjlkfBm5icg-1; Tue, 28 Jul 2020 10:50:43 -0400 X-MC-Unique: OJUGkaLdOH-cjlkfBm5icg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B6E7100AA24 for ; Tue, 28 Jul 2020 14:50:41 +0000 (UTC) Received: from [10.10.118.248] (ovpn-118-248.rdu2.redhat.com [10.10.118.248]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFC9A90E70; Tue, 28 Jul 2020 14:50:40 +0000 (UTC) Subject: Re: [PATCH for-5.1?] qapi/block-core.json: Remove stale description of 'blockdev-add' To: Kashyap Chamarthy , qemu-devel@nongnu.org References: <20200728143202.616687-1-kchamart@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 28 Jul 2020 09:50:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728143202.616687-1-kchamart@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/28 10:31:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/28/20 9:32 AM, Kashyap Chamarthy wrote: > On a 'qemu-discuss' thread[1], Kevin identifies that the current doc > blurb for @blockdev-add is stale: > > This is actually a documentation bug. @id doesn't exist, > blockdev-add never creates a BlockBackend. This was different in the > very first versions of the patches to add blockdev-add and we > probably just forgot to update the documentation after removing it. > > So remove the stale bits. > > And the requirement for 'node-name' is already mentioned in the > documentation of @BlockdevOptions: > > [...] > # @node-name: the node name of the new node (Since 2.0). > # This option is required on the top level of blockdev-add. > # Valid node names start with an alphabetic character and may > # contain only alphanumeric characters, '-', '.' and '_'. Their > # maximum length is 31 characters. > [...] > > [1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html > -- equivalent to "-drive if=ide,id=disk0....." > > Signed-off-by: Kashyap Chamarthy > Identified-by: Kevin Wolf This would be our first use of this unusual tag name; more typical is Suggested-by or Reported-by. Is it worth a 'Fixes: be4b67bc7d' line? > --- > qapi/block-core.json | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 463ffd83da..3575d73ebf 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -4049,9 +4049,7 @@ > ## > # @blockdev-add: > # > -# Creates a new block device. If the @id option is given at the top level, a > -# BlockBackend will be created; otherwise, @node-name is mandatory at the top > -# level and no BlockBackend will be created. > +# Creates a new block device. Reviewed-by: Eric Blake As a doc fix, it is safe for 5.1, but given the timing of -rc2 today, it's also okay if it slips into 5.2. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org