From: Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
armbru@redhat.com, hreitz@redhat.com, v.sementsov-og@ya.ru,
yuriy.vasiliev@virtuozzo.com, jsnow@redhat.com
Subject: Re: [PATCH v2 2/3] qapi: nbd-export: allow select bitmaps by node/name pair
Date: Fri, 8 Apr 2022 23:27:42 +0300 [thread overview]
Message-ID: <f28af710-a1fd-7475-d74d-8fa46c3dd46f@mail.ru> (raw)
In-Reply-To: <20220316212855.ra54pckg3u6xgwzw@redhat.com>
17.03.2022 00:28, Eric Blake wrote:
>> +++ b/qapi/block-export.json
>> @@ -6,6 +6,7 @@
>> ##
>>
>> { 'include': 'sockets.json' }
>> +{ 'include': 'block-core.json' }
> Hmm. Does this extra inclusion negatively impact qemu-storage-daemon,
> since that is why we created block-export.json in the first place (to
> minimize the stuff that qsd pulled in without needing all of
> block-core.json)? In other words, would it be better to move
> BlockDirtyBitmapOrStr to this file?
Actually, looking at storage-daemon/qapi/qapi-schema.json I see block-cores.json.
That's block.json which is not mentioned in storage-daemon/qapi/qapi-schema.json.
So, I think it's OK to keep simple include for now.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2022-04-08 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:32 [PATCH v2 for-7.1 0/3] qapi: nbd-export: select bitmap by node/name pair Vladimir Sementsov-Ogievskiy
2022-03-14 21:32 ` [PATCH v2 1/3] qapi: rename BlockDirtyBitmapMergeSource to BlockDirtyBitmapOrStr Vladimir Sementsov-Ogievskiy
2022-03-16 21:18 ` Eric Blake
2022-03-23 1:31 ` John Snow
2022-03-14 21:32 ` [PATCH v2 2/3] qapi: nbd-export: allow select bitmaps by node/name pair Vladimir Sementsov-Ogievskiy
2022-03-16 21:28 ` Eric Blake
2022-03-21 11:50 ` Vladimir Sementsov-Ogievskiy
2022-03-21 13:30 ` Eric Blake
2022-04-08 20:27 ` Vladimir Sementsov-Ogievskiy [this message]
2022-04-22 20:04 ` Eric Blake
2022-03-14 21:32 ` [PATCH v2 3/3] iotests/223: check new possibility of exporting bitmaps by node/name Vladimir Sementsov-Ogievskiy
2022-03-16 22:01 ` Eric Blake
2022-03-14 21:45 ` [PATCH v2 for-7.1 0/3] qapi: nbd-export: select bitmap by node/name pair Vladimir Sementsov-Ogievskiy
2022-04-22 20:09 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f28af710-a1fd-7475-d74d-8fa46c3dd46f@mail.ru \
--to=v.sementsov-og@mail.ru \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@ya.ru \
--cc=yuriy.vasiliev@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).