From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmF5M-0000JA-7B for qemu-devel@nongnu.org; Tue, 20 Sep 2016 03:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmF5H-00083k-Kb for qemu-devel@nongnu.org; Tue, 20 Sep 2016 03:03:19 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:51822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmF5H-00083G-B1 for qemu-devel@nongnu.org; Tue, 20 Sep 2016 03:03:15 -0400 References: <20160919114456.66629-1-aleksandar.markovic@rt-rk.com> <20160919114456.66629-2-aleksandar.markovic@rt-rk.com> From: Laurent Vivier Message-ID: Date: Tue, 20 Sep 2016 09:02:28 +0200 MIME-Version: 1.0 In-Reply-To: <20160919114456.66629-2-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v7 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic , qemu-devel@nongnu.org, riku.voipio@iki.fi, peter.maydell@linaro.org, aurelien@aurel32.net, leon.alrae@imgtec.com, petar.jovanovic@imgtec.com, miodrag.dinic@imgtec.com, aleksandar.rikalo@imgtec.com, aleksandar.markovic@imgtec.com Le 19/09/2016 à 13:44, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > This patch fixes wrong definition of TARGET_SIOCATMARK for mips, > alpha, and sh4. > > The current definition is: > > #define SIOCATMARK 0x8905 > > while the correct definition is: > > #define SIOCATMARK TARGET_IOR('s', 7, int) > > See Linux kernel source file arch/mips/include/uapi/asm/sockios.h#L19 > for reference. > > This patch also a fixes LTP test failure for test sockioctl01, for > mips, alpha, and sh4. > > Signed-off-by: Aleksandar Rikalo > Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier > --- > linux-user/syscall_defs.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > index c0c9b58..605496d 100644 > --- a/linux-user/syscall_defs.h > +++ b/linux-user/syscall_defs.h > @@ -898,7 +898,11 @@ struct target_pollfd { > #define TARGET_KDSETLED 0x4B32 /* set led state [lights, not flags] */ > #define TARGET_KDSIGACCEPT 0x4B4E > > +#if defined(TARGET_ALPHA) || defined(TARGET_MIPS) || defined(TARGET_SH4) > +#define TARGET_SIOCATMARK TARGET_IOR('s', 7, int) > +#else > #define TARGET_SIOCATMARK 0x8905 > +#endif > > /* Networking ioctls */ > #define TARGET_SIOCADDRT 0x890B /* add routing table entry */ >