From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 09/12] m25p80: Introduce an helper to retrieve the BlockBackend of a device
Date: Wed, 31 May 2023 09:47:09 +0200 [thread overview]
Message-ID: <f29df320-5392-b6c0-9bb4-c5f0330fe91c@linaro.org> (raw)
In-Reply-To: <516d4f95-a070-a03c-317c-2276cd42e871@kaod.org>
On 31/5/23 08:48, Cédric Le Goater wrote:
> On 5/30/23 23:14, Philippe Mathieu-Daudé wrote:
>> On 8/5/23 09:58, Cédric Le Goater wrote:
>>> It will help in getting rid of some drive_get(IF_MTD) calls by
>>> retrieving the BlockBackend directly from the m25p80 device.
>>>
>>> Cc: Alistair Francis <alistair@alistair23.me>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>> include/hw/block/flash.h | 4 ++++
>>> hw/block/m25p80.c | 6 ++++++
>>> 2 files changed, 10 insertions(+)
>>>
>>> diff --git a/include/hw/block/flash.h b/include/hw/block/flash.h
>>> index 7198953702..de93756cbe 100644
>>> --- a/include/hw/block/flash.h
>>> +++ b/include/hw/block/flash.h
>>> @@ -76,4 +76,8 @@ uint8_t ecc_digest(ECCState *s, uint8_t sample);
>>> void ecc_reset(ECCState *s);
>>> extern const VMStateDescription vmstate_ecc_state;
>>> +/* m25p80.c */
>>> +
>>> +BlockBackend *m25p80_get_blk(DeviceState *dev);
>>
>> - Option 1, declare QOM typedef and use proper type:
>>
>> #define TYPE_M25P80 "m25p80-generic"
>> OBJECT_DECLARE_TYPE(Flash, M25P80Class, M25P80)
>>
>> BlockBackend *m25p80_get_blk(Flash *dev);
>>
>> - Option 2, preliminary patch renaming 'Flash' type to
>> 'M25P80' then option 1 again
>
> That's a large change
Yes, it can be done later if you rather.
> and we would need to introduce a m25p80.h with
> these definitions.
FlashPartInfo is used as pointer so can be forward-declared.
Then we only need to move M25P80_INTERNAL_DATA_BUFFER_SZ.
For 5 lines, "hw/block/flash.h" is good enough IMO, keeping
all the rest to m25p80.c.
> Given that the caller needs a DeviceState in the
> end, may be not worth the extra hassle.
>
> How would you rename 'Flash' ? 'SpiFlash' ?
Since you ask, my preference is SpiNorFlash :)
But again, this can be done later on top.
Thanks,
Phil.
next prev parent reply other threads:[~2023-05-31 7:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 7:58 [PATCH 00/12] aspeed: fixes and extensions Cédric Le Goater
2023-05-08 7:58 ` [PATCH 01/12] aspeed/hace: Initialize g_autofree pointer Cédric Le Goater
2023-05-08 14:28 ` Francisco Iglesias
2023-05-30 21:30 ` Philippe Mathieu-Daudé
2023-05-08 7:58 ` [PATCH 02/12] aspeed: Introduce a boot_rom region at the machine level Cédric Le Goater
2023-05-08 14:27 ` Francisco Iglesias
2023-05-30 21:28 ` Philippe Mathieu-Daudé
2023-05-08 7:58 ` [PATCH 03/12] aspeed: Use the boot_rom region of the fby35 machine Cédric Le Goater
2023-05-30 21:27 ` Philippe Mathieu-Daudé
2023-05-31 5:57 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 04/12] hw/ssi: Add an "addr" property to SSIPeripheral Cédric Le Goater
2023-05-30 20:33 ` Philippe Mathieu-Daudé
2023-05-31 5:58 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 05/12] hw/ssi: Introduce a ssi_get_cs() helper Cédric Le Goater
2023-05-30 20:34 ` Philippe Mathieu-Daudé
2023-05-30 21:15 ` Philippe Mathieu-Daudé
2023-05-31 5:59 ` Cédric Le Goater
2023-05-31 6:17 ` Philippe Mathieu-Daudé
2023-05-31 6:36 ` Cédric Le Goater
2023-05-31 7:39 ` Philippe Mathieu-Daudé
2023-06-05 5:57 ` Bernhard Beschow
2023-06-05 16:21 ` Cédric Le Goater
2023-05-31 5:58 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 06/12] aspeed/smc: Wire CS lines at reset Cédric Le Goater
2023-05-30 20:56 ` Philippe Mathieu-Daudé
2023-05-31 6:14 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 07/12] hw/ssi: Check for duplicate addresses Cédric Le Goater
2023-05-30 21:05 ` Philippe Mathieu-Daudé
2023-05-31 6:20 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 08/12] aspeed: Create flash devices only when defaults are enabled Cédric Le Goater
2023-05-08 7:58 ` [PATCH 09/12] m25p80: Introduce an helper to retrieve the BlockBackend of a device Cédric Le Goater
2023-05-30 21:14 ` Philippe Mathieu-Daudé
2023-05-31 6:48 ` Cédric Le Goater
2023-05-31 7:47 ` Philippe Mathieu-Daudé [this message]
2023-05-08 7:58 ` [PATCH 10/12] aspeed: Get the BlockBackend of FMC0 from the flash device Cédric Le Goater
2023-05-30 21:08 ` Philippe Mathieu-Daudé
2023-05-08 7:58 ` [PATCH 11/12] aspeed: Introduce a "uart" machine option Cédric Le Goater
2023-05-30 21:22 ` Philippe Mathieu-Daudé
2023-05-31 6:28 ` Cédric Le Goater
2023-05-31 7:50 ` Philippe Mathieu-Daudé
2023-05-31 8:47 ` Cédric Le Goater
2023-05-08 7:58 ` [PATCH 12/12] target/arm: Allow users to set the number of VFP registers Cédric Le Goater
2023-05-30 15:03 ` [PATCH 00/12] aspeed: fixes and extensions Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f29df320-5392-b6c0-9bb4-c5f0330fe91c@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).