qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: mst@redhat.com
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Xie Yongji <xieyongji@bytedance.com>,
	jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
Date: Thu, 3 Jun 2021 15:16:59 +0200	[thread overview]
Message-ID: <f2a8e69d-75b1-6be0-f588-afe67cda3af9@redhat.com> (raw)
In-Reply-To: <d00aed97-cc58-0c8a-dc7d-9ae8945c3af4@redhat.com>

Hi Michael,

Could you queue this patch via your 'vhost' tree?

On 5/17/21 3:11 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
> 
> On 5/17/21 2:32 PM, Xie Yongji wrote:
>> The symbol address_space_memory are already declared in
>> include/exec/address-spaces.h. So let's add this header file
>> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>>
>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  hw/virtio/vhost-vdpa.c         | 1 +
>>  include/hw/virtio/vhost-vdpa.h | 1 -
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>> index 8f2fb9f10b2a..ee51863d280b 100644
>> --- a/hw/virtio/vhost-vdpa.c
>> +++ b/hw/virtio/vhost-vdpa.c
>> @@ -18,6 +18,7 @@
>>  #include "hw/virtio/vhost-backend.h"
>>  #include "hw/virtio/virtio-net.h"
>>  #include "hw/virtio/vhost-vdpa.h"
>> +#include "exec/address-spaces.h"
>>  #include "qemu/main-loop.h"
>>  #include "cpu.h"
>>  #include "trace.h"
>> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
>> index 28ca65018ed7..ae9ee7adb2d0 100644
>> --- a/include/hw/virtio/vhost-vdpa.h
>> +++ b/include/hw/virtio/vhost-vdpa.h
>> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
>>      struct vhost_dev *dev;
>>  } VhostVDPA;
>>  
>> -extern AddressSpace address_space_memory;
>>  #endif
>>
> 



  reply	other threads:[~2021-06-03 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 12:32 [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory Xie Yongji
2021-05-17 13:11 ` Philippe Mathieu-Daudé
2021-06-03 13:16   ` Philippe Mathieu-Daudé [this message]
2021-05-17 16:41 ` Stefano Garzarella
2021-06-05 19:34 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2a8e69d-75b1-6be0-f588-afe67cda3af9@redhat.com \
    --to=philmd@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).