* [PATCH v2] usb: fix kconfig for usb-xhci-sysbus
@ 2020-11-20 15:45 Paolo Bonzini
2020-11-20 15:52 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-11-20 15:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Bruce Rogers
Remove the "default y" for USB_XHCI_SYSBUS because
sysbus devices are not user creatable; boards that use them will
specify them manually with "imply" or "select" clauses.
It would be nice to keep the ability to remove PCIe and USB from microvm,
since thos can be disabled on the command line and therefore should not
be included if QEMU is configured --without-default-devices. However
it's too late for 5.2 to figure out a place for the DSDT creation code.
Reported-by: Bruce Rogers <brogers@suse.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/usb/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 3b07d9cf68..7fbae18bc8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -47,7 +47,6 @@ config USB_XHCI_NEC
config USB_XHCI_SYSBUS
bool
- default y
select USB_XHCI
config USB_MUSB
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus
2020-11-20 15:45 [PATCH v2] usb: fix kconfig for usb-xhci-sysbus Paolo Bonzini
@ 2020-11-20 15:52 ` Philippe Mathieu-Daudé
2020-11-20 16:27 ` Bruce Rogers
2020-11-23 6:57 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-20 15:52 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Gerd Hoffmann, Bruce Rogers
On 11/20/20 4:45 PM, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
>
> It would be nice to keep the ability to remove PCIe and USB from microvm,
> since thos can be disabled on the command line and therefore should not
Typo "those"
> be included if QEMU is configured --without-default-devices. However
> it's too late for 5.2 to figure out a place for the DSDT creation code.
:(
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 3b07d9cf68..7fbae18bc8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -47,7 +47,6 @@ config USB_XHCI_NEC
>
> config USB_XHCI_SYSBUS
> bool
> - default y
> select USB_XHCI
>
> config USB_MUSB
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus
2020-11-20 15:45 [PATCH v2] usb: fix kconfig for usb-xhci-sysbus Paolo Bonzini
2020-11-20 15:52 ` Philippe Mathieu-Daudé
@ 2020-11-20 16:27 ` Bruce Rogers
2020-11-23 6:57 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Bruce Rogers @ 2020-11-20 16:27 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Gerd Hoffmann
On Fri, 2020-11-20 at 10:45 -0500, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
>
> It would be nice to keep the ability to remove PCIe and USB from
> microvm,
> since thos can be disabled on the command line and therefore should
> not
> be included if QEMU is configured --without-default-devices. However
> it's too late for 5.2 to figure out a place for the DSDT creation
> code.
>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 3b07d9cf68..7fbae18bc8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -47,7 +47,6 @@ config USB_XHCI_NEC
>
> config USB_XHCI_SYSBUS
> bool
> - default y
> select USB_XHCI
>
> config USB_MUSB
Tested-by: Bruce Rogers <brogers@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus
2020-11-20 15:45 [PATCH v2] usb: fix kconfig for usb-xhci-sysbus Paolo Bonzini
2020-11-20 15:52 ` Philippe Mathieu-Daudé
2020-11-20 16:27 ` Bruce Rogers
@ 2020-11-23 6:57 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2020-11-23 6:57 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Bruce Rogers
On Fri, Nov 20, 2020 at 10:45:06AM -0500, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
>
> It would be nice to keep the ability to remove PCIe and USB from microvm,
> since thos can be disabled on the command line and therefore should not
> be included if QEMU is configured --without-default-devices. However
> it's too late for 5.2 to figure out a place for the DSDT creation code.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-23 6:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-20 15:45 [PATCH v2] usb: fix kconfig for usb-xhci-sysbus Paolo Bonzini
2020-11-20 15:52 ` Philippe Mathieu-Daudé
2020-11-20 16:27 ` Bruce Rogers
2020-11-23 6:57 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).