From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6D5C56201 for ; Fri, 20 Nov 2020 16:28:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C55552225B for ; Fri, 20 Nov 2020 16:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="OXhxgS24" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C55552225B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg9HM-0002Lh-LV for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 11:28:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg9Fp-0000Zr-5f for qemu-devel@nongnu.org; Fri, 20 Nov 2020 11:27:21 -0500 Received: from de-smtp-delivery-52.mimecast.com ([51.163.158.52]:42050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kg9Fm-0006Yq-R3 for qemu-devel@nongnu.org; Fri, 20 Nov 2020 11:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1605889636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nXitTtr13wHTAjasbrTbBmqNFKosWobU8fqCA+owREI=; b=OXhxgS243OUjY4d51fENDA1HnTfn1bjHRQ/4zzosDStC5e2Lu9SzBNgbVGSLMCI6jQul9o fNni6oaclp+GZ37zD1CZn+UuAVA9V9i/4PzfoSXsXkxfz21gyjF7fnnXHDXyyHVwzgxFCY yRDNXzI1NWhg9SMdJCe7579TiRBpjgY= Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-yg130XVTPWmUViZkn5irig-1; Fri, 20 Nov 2020 17:27:14 +0100 X-MC-Unique: yg130XVTPWmUViZkn5irig-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiI8fjbiGvmZz76dxrmIYw2KS8V0PkcEVDTKfoTMiWzU83XU94OHjKJYGcBLhAxAPPEIq8pXdau0Ef6SqBhpB+nlS5c/eEguaNkpLIiRLWZ5tRcZ4hX03hUnYSFUtg+4MhGIKIFxn7JwMVDaGm8jre5Y0ZxOVBqdDr/TEipfKzF/Nws4C40T6lckJnz8/tiJomg0GLKwNl6ggv/8ORHIx3HfUv9MD8YjObtsqK9xCB4IaUYz7jT3wzoloHR8TgP/2J79UzbIgtuqwC8mgjf4GcYGqNdE02Ip4fzhJO2CWLWGMZ3k/rjdGxg/DEg8PesHQYeG2KWjD4wAGkwwq+h51Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nXitTtr13wHTAjasbrTbBmqNFKosWobU8fqCA+owREI=; b=PdQMXf4ypebN4M0CBbNDmtKKhZVvtaUGLAMAyYcnyefTskiPNgwfssEt6jYwTOU185V1aOLdzFfOkX2hRJASx0IxbwqEj0HH4vrpRPvZRrpk4WYtE7PqrEc4QdQExKP/v+G97+vlM+hCfrdz0hJXY7LCx2WLENR19wjKgGVDFEm/LLMRkJ77K/IX2N9+8+Twt23JJtDM0NI1kDUfrjjyOwaemBBd4zz7knwW/31Qjm7+BpYBB0iM55DRcgaO0uG41z6xTHpaM8QvLb6wi9eJYsk4ZhKkyxr8CIrZtMKt+n+l37oepzZa8VR31V/6I34t60xSMmNFnDZmHb659F3FPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=suse.com; Received: from AM4PR0401MB2354.eurprd04.prod.outlook.com (2603:10a6:200:54::21) by AM0PR04MB5203.eurprd04.prod.outlook.com (2603:10a6:208:c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Fri, 20 Nov 2020 16:27:13 +0000 Received: from AM4PR0401MB2354.eurprd04.prod.outlook.com ([fe80::9891:ed4f:b5a2:6441]) by AM4PR0401MB2354.eurprd04.prod.outlook.com ([fe80::9891:ed4f:b5a2:6441%6]) with mapi id 15.20.3564.028; Fri, 20 Nov 2020 16:27:13 +0000 Message-ID: Subject: Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus From: Bruce Rogers To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Gerd Hoffmann Date: Fri, 20 Nov 2020 09:27:06 -0700 In-Reply-To: <20201120154506.2496906-1-pbonzini@redhat.com> References: <20201120154506.2496906-1-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 Content-Transfer-Encoding: 7bit X-Originating-IP: [63.248.145.198] X-ClientProxiedBy: AM0PR10CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::17) To AM4PR0401MB2354.eurprd04.prod.outlook.com (2603:10a6:200:54::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.12] (63.248.145.198) by AM0PR10CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Fri, 20 Nov 2020 16:27:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24122cf7-94b4-4721-b465-08d88d7122f6 X-MS-TrafficTypeDiagnostic: AM0PR04MB5203: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qmly4YdffuAb0vWcJo7X4zloM4SdBao98s7ldhHM9EwhRUm2ipz1nv8hyTJaZ2W1U+0QIWXBbzv4EixW1jtsnlw/atMZyGvwpRBY+3pVW66+6vT5ncKnWZ36rzjdKd8LxleIvyIATunUS69c5xanznQ9TYfthJheUkanMOcPRtsgUziHY3Zv4rlALr/w2UsCu24qCmNwbq7dNjyy4MpCjyla4/fFtRBuA2oAkH6DPKyVC4Sj4US1+qbahvwWUjjbkZHQOmSSSJE/pgECPLx/VOzJeTA9XG3TksIMkSz6AcSk5g4B0qdNnpJo6qo/RHcpbx93SQnYDtMysJgNPwrTZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR0401MB2354.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(39860400002)(376002)(366004)(396003)(956004)(4326008)(186003)(316002)(5660300002)(16526019)(6486002)(8676002)(16576012)(86362001)(2616005)(83380400001)(478600001)(52116002)(26005)(8936002)(6666004)(4001150100001)(66476007)(2906002)(36756003)(66946007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: X9LPIyzBKbBoRZiDkVch6EQn58Fv2UDeecAcUunK7HggFk7LD8+9DzoSfMMWyKKb16N3NmfpdsNXSp5enTVRzafNjx/zzSp9iTyJbEyDwqxtOdh7utWmwI0EmNtuk3lxlJjGiiAmZHg5qKy6ALKoKvFjssfkjCuGNKy7Tm5EzYwEvUPP/utZoFYBQc5TBz4Q178eSVrWgl3mPWIyi+HvxgBDWEa3zs0qKstY2i4wcKT/IfS+5opZv7nV2Qi7sJtRDcy3thGFfZ1Kooi4JuMCb/w40P1FYQO/slHqi69NdOiCC6PJscWL3rnkOHJpu2x/qmEVesy331ygRT+TFWTH6bDV3VF+tVDfXTIdxp2TDohe5IwfG77hSt7Mg7BVwLnX55/KXRz560dR2SCzzkZgHO+KZPtPAZTxTqbr3o2BRht1uSDJqdagbHrMB5Z/xD14lr6uXn8s4072EkvI0Llptvb7iLS1hEojsig9krAjIWu7GLw90l7aM/I0+55W+pniF/l0wgioOdXRxXmIsMS4bbmG6M4VSKIePh39VBtdVWHpx8tbXZf5ZNu3Yu/HroBdQ4eewCPZl02AkbFVjmXp6FTqz/oiVIF1r7hCDwGw71txHeF9Qvv1sBwUwAa9oxsi37/wS+maTKRQsepKJDd24w== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24122cf7-94b4-4721-b465-08d88d7122f6 X-MS-Exchange-CrossTenant-AuthSource: AM4PR0401MB2354.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2020 16:27:13.3717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GTJeDvvX4MF22xshAuVRim7MCBPWiGjukJ5Jy7td1Oz9ElgdpjJi0CJ7Iti6B+PjXEzNP9tbWKRC6mvJP+xXRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5203 Received-SPF: pass client-ip=51.163.158.52; envelope-from=brogers@suse.com; helo=de-smtp-delivery-52.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 2020-11-20 at 10:45 -0500, Paolo Bonzini wrote: > Remove the "default y" for USB_XHCI_SYSBUS because > sysbus devices are not user creatable; boards that use them will > specify them manually with "imply" or "select" clauses. > > It would be nice to keep the ability to remove PCIe and USB from > microvm, > since thos can be disabled on the command line and therefore should > not > be included if QEMU is configured --without-default-devices. However > it's too late for 5.2 to figure out a place for the DSDT creation > code. > > Reported-by: Bruce Rogers > Cc: Gerd Hoffmann > Signed-off-by: Paolo Bonzini > --- > hw/usb/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig > index 3b07d9cf68..7fbae18bc8 100644 > --- a/hw/usb/Kconfig > +++ b/hw/usb/Kconfig > @@ -47,7 +47,6 @@ config USB_XHCI_NEC > > config USB_XHCI_SYSBUS > bool > - default y > select USB_XHCI > > config USB_MUSB Tested-by: Bruce Rogers