From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, xiezhide@huawei.com, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate
Date: Thu, 15 Nov 2018 23:59:35 +0100 [thread overview]
Message-ID: <f2b24e02-3a9c-5408-71ab-8c3b252851ff@redhat.com> (raw)
In-Reply-To: <20181115225052.1322639-1-eblake@redhat.com>
On 15/11/2018 23:50, Eric Blake wrote:
> Adding a new qapi module requires some rather tedious repetition to
> wire it into Makefile and Makefile.objs. Add some indirection by
> taking advantage of GNU Make string processing to expand a list
> of module names into all the required artifacts, so that future
> additions of a new module need only touch the list of module names.
>
> The list has to live in Makefile.objs, due to the way that
> unnest-vars slirps in that file without remembering any definition
> of $(QAPI_MODULES) from Makefile.
I don't see offhand why that would happen; Makefile.objs is simply
included from Makefile. Anyway, if this works it's okay as well.
Feel free to send me the non-working patch offlist.
Paolo
next prev parent reply other threads:[~2018-11-15 22:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 22:50 [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate Eric Blake
2018-11-15 22:59 ` Paolo Bonzini [this message]
2018-11-16 10:17 ` Markus Armbruster
2018-11-16 10:26 ` Daniel P. Berrangé
2018-11-16 15:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b24e02-3a9c-5408-71ab-8c3b252851ff@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiezhide@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).