From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNQc4-0002WB-0e for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:59:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNQc2-0006ot-RG for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:59:51 -0500 References: <20181115225052.1322639-1-eblake@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 15 Nov 2018 23:59:35 +0100 MIME-Version: 1.0 In-Reply-To: <20181115225052.1322639-1-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: armbru@redhat.com, xiezhide@huawei.com, qemu-trivial@nongnu.org On 15/11/2018 23:50, Eric Blake wrote: > Adding a new qapi module requires some rather tedious repetition to > wire it into Makefile and Makefile.objs. Add some indirection by > taking advantage of GNU Make string processing to expand a list > of module names into all the required artifacts, so that future > additions of a new module need only touch the list of module names. >=20 > The list has to live in Makefile.objs, due to the way that > unnest-vars slirps in that file without remembering any definition > of $(QAPI_MODULES) from Makefile. I don't see offhand why that would happen; Makefile.objs is simply included from Makefile. Anyway, if this works it's okay as well. Feel free to send me the non-working patch offlist. Paolo