From: Eric Blake <eblake@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz
Date: Mon, 15 Mar 2021 14:11:45 -0500 [thread overview]
Message-ID: <f2b73aa5-6d68-405f-82d4-e57d0ff23de0@redhat.com> (raw)
In-Reply-To: <20210315185117.1986240-2-richard.henderson@linaro.org>
On 3/15/21 1:51 PM, Richard Henderson wrote:
> Once we've parsed the fractional value, extract it into an integral
> 64-bit fraction. Perform the scaling with integer arithmetic, and
> simplify the overflow detection.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Message-Id: <20210315155835.1970210-2-richard.henderson@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
A bit late now that it's in a pull request, but adding
Fixes: cf923b783efd5 (utils: Improve qemu_strtosz() to have 64 bits of
precision)
would have been nice.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-03-15 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 18:51 [PULL 0/1] Fix qemu_strtosz regression Richard Henderson
2021-03-15 18:51 ` [PULL 1/1] utils: Use fixed-point arithmetic in qemu_strtosz Richard Henderson
2021-03-15 19:11 ` Eric Blake [this message]
2021-03-17 9:06 ` [PULL 0/1] Fix qemu_strtosz regression Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b73aa5-6d68-405f-82d4-e57d0ff23de0@redhat.com \
--to=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).