Re: [Qemu-devel] [PATCH v1 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD

[David Hildenbrand <david@redhat.com>]

On 06.12.2017 16:10, Thomas Huth wrote:
> On 04.12.2017 13:55, David Hildenbrand wrote:
>> Needed for machine check handling inside Linux (when restoring registers).
>>
>> Except for SIGP and machine checks, we don't make use of the register
>> yet. Suficient for now.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
> [...]
>> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
>> index 6d766ce1e7..2c6ab329fb 100644
>> --- a/target/s390x/misc_helper.c
>> +++ b/target/s390x/misc_helper.c
>> @@ -146,6 +146,17 @@ void HELPER(sckc)(CPUS390XState *env, uint64_t time)
>>      timer_mod(env->tod_timer, env->tod_basetime + time);
>>  }
>>  
>> +/* Set Tod Programmable Field */
>> +void HELPER(sckpf)(CPUS390XState *env)
>> +{
>> +    uint32_t val = env->regs[0];
>> +
>> +    if (val & 0xffff0000UL) {
> 
> I think you could drop the "UL" suffix here.
> 

Indeed, we should be fine as long as this fits into an int thanks!


-- 

Thanks,

David / dhildenb