qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 00/12] audio: deprecate -soundhw
Date: Wed, 29 Apr 2020 18:54:08 +0200	[thread overview]
Message-ID: <f2d7187a-953c-2b53-07fb-0a3e5f32193d@redhat.com> (raw)
In-Reply-To: <20200429110214.29037-1-kraxel@redhat.com>

Hi Gerd,

On 4/29/20 1:02 PM, Gerd Hoffmann wrote:
> 
> 
> Gerd Hoffmann (12):
>    stubs: add isa_create_simple
>    stubs: add pci_create_simple
>    audio: add deprecated_register_soundhw
>    audio: deprecate -soundhw ac97
>    audio: deprecate -soundhw es1370
>    audio: deprecate -soundhw adlib
>    audio: deprecate -soundhw cs4231a
>    audio: deprecate -soundhw gus
>    audio: deprecate -soundhw sb16
>    audio: deprecate -soundhw hda
>    audio: deprecate -soundhw pcspk
>    [RFC] audio: try use onboard audiodev for pcspk

I don't understand what you are trying to fix with this series.

I suppose there is a problem with the pcspk, as I had a problem when I 
tried to make the soundhw more QOM-friendly. pcspk needs rethink and 
some work so I didn't finished. Also I had a problem with intel-hda. I 
see in your series both are handled differently. I'll send the patch 
with the broken code marked XXX, maybe you can it figure out.

> 
>   include/hw/audio/soundhw.h |  2 ++
>   hw/audio/ac97.c            |  9 ++-------
>   hw/audio/adlib.c           |  8 +-------
>   hw/audio/cs4231a.c         |  8 +-------
>   hw/audio/es1370.c          |  9 ++-------
>   hw/audio/gus.c             |  8 +-------
>   hw/audio/intel-hda.c       |  3 +++
>   hw/audio/pcspk.c           | 27 ++++++++++++++++++++++++---
>   hw/audio/sb16.c            |  9 ++-------
>   hw/audio/soundhw.c         | 24 +++++++++++++++++++++++-
>   qdev-monitor.c             |  2 ++
>   stubs/isa-bus.c            |  7 +++++++
>   stubs/pci-bus.c            |  7 +++++++
>   stubs/Makefile.objs        |  2 ++
>   14 files changed, 79 insertions(+), 46 deletions(-)
>   create mode 100644 stubs/isa-bus.c
>   create mode 100644 stubs/pci-bus.c
> 



  parent reply	other threads:[~2020-04-29 16:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 11:02 [PATCH 00/12] audio: deprecate -soundhw Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 01/12] stubs: add isa_create_simple Gerd Hoffmann
2020-04-30  7:12   ` Philippe Mathieu-Daudé
2020-04-29 11:02 ` [PATCH 02/12] stubs: add pci_create_simple Gerd Hoffmann
2020-04-30  7:12   ` Philippe Mathieu-Daudé
2020-04-29 11:02 ` [PATCH 03/12] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 04/12] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 05/12] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 06/12] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 07/12] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 08/12] audio: deprecate -soundhw gus Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 09/12] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 10/12] audio: deprecate -soundhw hda Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 11/12] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-04-29 11:02 ` [PATCH 12/12] [RFC] audio: try use onboard audiodev for pcspk Gerd Hoffmann
2020-04-29 11:04 ` [PATCH 00/12] audio: deprecate -soundhw Daniel P. Berrangé
2020-04-29 16:54 ` Philippe Mathieu-Daudé [this message]
2020-04-30  7:41   ` Gerd Hoffmann
2020-04-30  8:03     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d7187a-953c-2b53-07fb-0a3e5f32193d@redhat.com \
    --to=philmd@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).