qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Srikanth Aithal <srikanth.aithal@amd.com>,
	qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com
Cc: nikunj@amd.com
Subject: Re: [PATCH] target/i386/sev: Fix a segfault in sev_kvm_init
Date: Thu, 4 Jan 2024 14:48:53 +0100	[thread overview]
Message-ID: <f2d83840-17cb-433f-add9-d7e05448a280@linaro.org> (raw)
In-Reply-To: <20240104104820.14422-1-srikanth.aithal@amd.com>

On 4/1/24 11:48, Srikanth Aithal wrote:
> Propogate error code using errp in sev_kvm_init.
> 
> Before fix:
> qemu-system-x86_64: sev_kvm_init: guest policy requires SEV-ES,
> but host SEV-ES support unavailable
> 27747 Segmentation fault      (core dumped)
> 
> After fix:
> qemu-system-x86_64: sev_kvm_init: guest policy requires SEV-ES,
> but host SEV-ES support unavailable
> qemu-system-x86_64: failed to initialize kvm: Operation not permitted
> 
> While at it, also fix two more locations.
> 
> Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>
> Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
> ---
>   target/i386/sev.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2024-01-04 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 10:48 [PATCH] target/i386/sev: Fix a segfault in sev_kvm_init Srikanth Aithal
2024-01-04 13:48 ` Philippe Mathieu-Daudé [this message]
2024-01-04 16:27 ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d83840-17cb-433f-add9-d7e05448a280@linaro.org \
    --to=philmd@linaro.org \
    --cc=mtosatti@redhat.com \
    --cc=nikunj@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=srikanth.aithal@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).