Re: [PATCH RFC] tests/functional: add tests for SCLP event CPI

[Shalini Chellathurai Saroja <shalini@linux.ibm.com>]

On 2025-08-25 13:30, Thomas Huth wrote:
> On 12/08/2025 14.31, Shalini Chellathurai Saroja wrote:
>> Add tests for SCLP event type Control-Program Identification
>> (CPI) to s390x CCW virtio tests.
>> 
>> Please note that these tests are skipped as the guest OS does not
>> trigger the SCLP event type CPI when the command
>> 'echo 1 > /sys/firmware/cpi/set' is executed in the guest. I
>> believe that the guest OS must to be updated to support the SCLP
>> event type CPI.
>> 
>> Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> ---
> ...
>> +        try:
>> +            event = self.vm.event_wait('SCLP_EVENT_CTRL_PGM_ID')
> 
> As far as I can tell, SCLP_EVENT_CTRL_PGM_ID is an *SCLP* event only,
> but you're trying to wait for a *QAPI* event here instead. That's two
> completely different things, SCLP events are something between the
> guest and QEMU, while QAPI events are between QEMU and the monitoring
> program (i.e. in this case the test).
> 
> If you want that QEMU generates such QAPI events for the monitoring
> program, you have to do something similar to commit 1cfe52b78240679
> and add the qapi_event_send_... function to the right spot in your
> code.
> 

Hello Thomas,

I have added the QAPI event and have sent the v2 of this patch.
Thank you very much.


>  HTH,
>   Thomas

-- 
Mit freundlichen Grüßen / Kind regards
Shalini Chellathurai Saroja
Software Developer
Linux on IBM Z & KVM Development
IBM Deutschland Research & Development GmbH
Dept 1419, Schoenaicher Str. 220, 71032 Boeblingen
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht 
Stuttgart, HRB 243294