From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A38C43613 for ; Mon, 24 Jun 2019 13:38:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F27B1208E4 for ; Mon, 24 Jun 2019 13:38:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F27B1208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPAi-0003pQ-7S for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 09:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39815) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPA3-0003Cq-P4 for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfPA2-00081H-Ex for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:37:31 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfPA2-0007yq-8k for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:37:30 -0400 Received: by mail-wr1-f66.google.com with SMTP id x4so13948795wrt.6 for ; Mon, 24 Jun 2019 06:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CnJSmYXRNYTaiFEUECAPy7ZStbOVoTEJkKEJXpEnYM8=; b=HegqDf9OL4qTFPdlablV4PYMn+bDRhaqswQu5lKbywfAJlxSvH1M0E+d12+kJ4XVSj fLv7hG2dgM22aWsC3Y5fPmKCUSMdGW4GY3tDXQOoSFJm6oxSgr4zWz8jVR7EPbj3xFI4 DRVIBKnY3qnpCYIf3CeIludi8j267WyZjze0nZPx7UC+PMnXlWt46kYVMrlfPdlGm5hc 0CVonqB/P2Qisc3DIJUt6b5DDJ/K+I8kjWCHebLt7jygJlJOyCAdE1OxnjG3UHRkRFOj juMkO2+9SfGdtURxoJS1oQY0WBHYogPuRtXkTrGlAdJ5Z5WF2PzogO0sr2Iv7N38qD3N GSXA== X-Gm-Message-State: APjAAAX7eZrqNcqqaRNhzFF5UxIGWgrbYJFy43NJjq3MWULOwDz9mkbQ UMo3hJ5lqsKsa7EORtxi3d2KVg== X-Google-Smtp-Source: APXvYqysbyuUrS5Hh8Px3BSpWbEIjP6bCv8DNy/as68QAemzr8z4vI5SawDg3z4rcOosauQdMjojqA== X-Received: by 2002:a05:6000:42:: with SMTP id k2mr62352507wrx.80.1561383447053; Mon, 24 Jun 2019 06:37:27 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:7822:aa18:a9d8:39ab? ([2001:b07:6468:f312:7822:aa18:a9d8:39ab]) by smtp.gmail.com with ESMTPSA id b9sm7573622wrm.11.2019.06.24.06.37.25 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 06:37:26 -0700 (PDT) From: Paolo Bonzini To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org References: <20190624123835.28869-1-alex.bennee@linaro.org> Message-ID: Date: Mon, 24 Jun 2019 15:37:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 Subject: Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vitaly Kuznetsov , Richard Henderson , qemu-devel@nongnu.org, Eduardo Habkost , Roman Kagan Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/06/19 15:22, Paolo Bonzini wrote: > On 24/06/19 14:38, Alex Bennée wrote: >> Commit 2d384d7c8 broken the build when built with: >> >> configure --without-default-devices --disable-user >> >> The reason was the conversion of cpu->hyperv_synic to >> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a >> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in >> hyperv-stub to do the same feature check as in the real hyperv.c >> >> Signed-off-by: Alex Bennée >> Cc: Vitaly Kuznetsov >> Cc: Paolo Bonzini >> Cc: Roman Kagan >> --- >> target/i386/hyperv-stub.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c >> index fe548cbae2..0028527e79 100644 >> --- a/target/i386/hyperv-stub.c >> +++ b/target/i386/hyperv-stub.c >> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit) >> { >> switch (exit->type) { >> case KVM_EXIT_HYPERV_SYNIC: >> - if (!cpu->hyperv_synic) { >> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) { >> return -1; >> } >> >> > > Queued, thanks. Alex will queue it instead, so Acked-by: Paolo Bonzini Paolo