* [PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p()
@ 2024-09-30 22:07 Philippe Mathieu-Daudé
2024-10-01 5:17 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-30 22:07 UTC (permalink / raw)
To: qemu-devel
Cc: Magnus Damm, Thomas Huth, Yoshinori Sato, Anton Johansson,
Philippe Mathieu-Daudé
Replace the target-specific tswap32() calls by stl_endian_p()
which does the same but takes the endianness as argument, thus
is target-agnostic.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Based-on: <20240930073450.33195-2-philmd@linaro.org>
"qemu/bswap: Introduce ld/st_endian_p() API"
---
hw/sh4/r2d.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index e5ac6751bd..6739ac435a 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -353,9 +353,11 @@ static void r2d_init(MachineState *machine)
}
/* initialization which should be done by firmware */
- boot_params.loader_type = tswap32(1);
- boot_params.initrd_start = tswap32(INITRD_LOAD_OFFSET);
- boot_params.initrd_size = tswap32(initrd_size);
+ stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.loader_type, 1);
+ stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_start,
+ INITRD_LOAD_OFFSET);
+ stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_size,
+ initrd_size);
}
if (kernel_cmdline) {
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p()
2024-09-30 22:07 [PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p() Philippe Mathieu-Daudé
@ 2024-10-01 5:17 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-10-01 5:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Magnus Damm, Yoshinori Sato, Anton Johansson
On 01/10/2024 00.07, Philippe Mathieu-Daudé wrote:
> Replace the target-specific tswap32() calls by stl_endian_p()
> which does the same but takes the endianness as argument, thus
> is target-agnostic.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20240930073450.33195-2-philmd@linaro.org>
> "qemu/bswap: Introduce ld/st_endian_p() API"
> ---
> hw/sh4/r2d.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
> index e5ac6751bd..6739ac435a 100644
> --- a/hw/sh4/r2d.c
> +++ b/hw/sh4/r2d.c
> @@ -353,9 +353,11 @@ static void r2d_init(MachineState *machine)
> }
>
> /* initialization which should be done by firmware */
> - boot_params.loader_type = tswap32(1);
> - boot_params.initrd_start = tswap32(INITRD_LOAD_OFFSET);
> - boot_params.initrd_size = tswap32(initrd_size);
> + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.loader_type, 1);
> + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_start,
> + INITRD_LOAD_OFFSET);
> + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_size,
> + initrd_size);
> }
I still don't quite get it - the tswap functions already use
target_words_bigendian() when being used in common code, so what do you
really gain by these changes?
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-01 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 22:07 [PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p() Philippe Mathieu-Daudé
2024-10-01 5:17 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).