From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 415EECEACDB for ; Tue, 1 Oct 2024 14:50:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sveCc-0001eh-Cz; Tue, 01 Oct 2024 10:50:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sveCT-0001K0-Tv for qemu-devel@nongnu.org; Tue, 01 Oct 2024 10:50:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sveCS-00058D-5d for qemu-devel@nongnu.org; Tue, 01 Oct 2024 10:50:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727794201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WHZimejTlJNNv6hp0Zcpv89/u5axwT1MRsR/8yD7+w8=; b=B3bAYboVo6n13tP/wNCmWLI8DVfJ7y002oQog+Glr9zGQqjwr/AjTdayQg4ALxBZ3AKcV7 OHD3cYAH8q1Opz+V/hs2DGIvtiwzicjq0lyxB4f+m6fwnP1QGIl6BUjVn2FJ+jFJOmUK0B PxNoI2B+BVwAfCiy9oQF0N0QJyeoH8Q= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-L4zkXaIwNx-ofn25YhA7DQ-1; Tue, 01 Oct 2024 01:17:45 -0400 X-MC-Unique: L4zkXaIwNx-ofn25YhA7DQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a8a84b60255so482207266b.1 for ; Mon, 30 Sep 2024 22:17:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727759864; x=1728364664; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WHZimejTlJNNv6hp0Zcpv89/u5axwT1MRsR/8yD7+w8=; b=XToYPZdiRTCJ/kdx4Koew/UsOp52Q9RqI8x8tNVTHElkgsgro8mYbUenz78IczZ5Nx zpnxUliGjvAp0Kt8IHNfqsTmut9A2e09oo53VxPRUTAjX6Upoz2ePg3D8ExCvExgMgiC zZXLTV5s7o8lKr2DpqOIjgLb6c2umRecGVAsGnuihicXIbxz+jGsUr5/SqvHTfkGnbDe mpnxXqFCfQ+JTpXT+DyXKfnKu64ZPhwnHs5CIzJgbWSgmMkV3aj2DWYNRHsh6/PQivgD RnwwAZOZx0ojhvhy5wX/hT84PZch+19MEyQp34OWvqaPAd7y7zBEiuwpQXafBAl6DeIS TnOQ== X-Forwarded-Encrypted: i=1; AJvYcCUQLM4M7oyCc5+cs7fkDcTucQ12pyU5PNChXcZDISgrKb6jgwRhjaYA48g/0h1jiqJg3lNt4xzx6Btc@nongnu.org X-Gm-Message-State: AOJu0Yxv8RP4+ADceziTM0lMfvLENc1clV1Begrqe1O+bzHq3UwQoZ/5 wPjSVMJ83T72LcDb1F2ShRUF8krpAX0HyM6kE92R9AuhH6DBiZYyGAQ+PDgIH7cZ7jouXGgdKwc DOZPD166YWZCkGaYwtS6na/Z2Q01mdQo/x3Plb/MFUaSdztkFqqRl X-Received: by 2002:a17:907:a4a:b0:a8b:6ee7:ba10 with SMTP id a640c23a62f3a-a93c4946dd7mr1557709066b.33.1727759864548; Mon, 30 Sep 2024 22:17:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVBjEmFF8CBGB9faWvfhamGSYR3plCl253+McQ5GRinGk3wjkLHTQzI4/7ox4YAc3R4VYjag== X-Received: by 2002:a17:907:a4a:b0:a8b:6ee7:ba10 with SMTP id a640c23a62f3a-a93c4946dd7mr1557707666b.33.1727759864124; Mon, 30 Sep 2024 22:17:44 -0700 (PDT) Received: from [192.168.0.7] (ip-109-42-49-143.web.vodafone.de. [109.42.49.143]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c27ecd10sm636129466b.96.2024.09.30.22.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 22:17:43 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 07:17:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p() To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Magnus Damm , Yoshinori Sato , Anton Johansson References: <20240930220732.58757-1-philmd@linaro.org> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240930220732.58757-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 01/10/2024 00.07, Philippe Mathieu-Daudé wrote: > Replace the target-specific tswap32() calls by stl_endian_p() > which does the same but takes the endianness as argument, thus > is target-agnostic. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20240930073450.33195-2-philmd@linaro.org> > "qemu/bswap: Introduce ld/st_endian_p() API" > --- > hw/sh4/r2d.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c > index e5ac6751bd..6739ac435a 100644 > --- a/hw/sh4/r2d.c > +++ b/hw/sh4/r2d.c > @@ -353,9 +353,11 @@ static void r2d_init(MachineState *machine) > } > > /* initialization which should be done by firmware */ > - boot_params.loader_type = tswap32(1); > - boot_params.initrd_start = tswap32(INITRD_LOAD_OFFSET); > - boot_params.initrd_size = tswap32(initrd_size); > + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.loader_type, 1); > + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_start, > + INITRD_LOAD_OFFSET); > + stl_endian_p(TARGET_BIG_ENDIAN, &boot_params.initrd_size, > + initrd_size); > } I still don't quite get it - the tswap functions already use target_words_bigendian() when being used in common code, so what do you really gain by these changes? Thomas