From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
dgilbert@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH for-5.1?] iotests: Adjust which tests are quick
Date: Mon, 27 Jul 2020 23:07:33 +0300 [thread overview]
Message-ID: <f304c499-0c4a-a179-c20e-af7fb8940b20@virtuozzo.com> (raw)
In-Reply-To: <20200727195117.132151-1-eblake@redhat.com>
27.07.2020 22:51, Eric Blake wrote:
> A quick run of './check -qcow2 -g migration' shows that test 169 is
> NOT quick, but meanwhile several other tests ARE quick. Let's adjust
> the test designations accordingly.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Still, why do we need quick group? make check uses "auto" group..
Some tests are considered important enough to run even not being quick.
Probably, everyone who don't want to run all tests, should run "auto" group,
not "quick"?
I, when want to check my changes, run all tests or limit them with
help of grep. I mostly run tests on tmpfs, so they all are quick enough.
Saving several minutes of cpu work doesn't worth missing a bug..
--
Best regards,
Vladimir
next prev parent reply other threads:[~2020-07-27 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 19:51 [PATCH for-5.1?] iotests: Adjust which tests are quick Eric Blake
2020-07-27 20:07 ` Vladimir Sementsov-Ogievskiy [this message]
2020-07-28 7:13 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f304c499-0c4a-a179-c20e-af7fb8940b20@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).