From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFD4C3A59F for ; Thu, 29 Aug 2019 16:19:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D73521874 for ; Thu, 29 Aug 2019 16:19:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D73521874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3N8c-0002lX-46 for qemu-devel@archiver.kernel.org; Thu, 29 Aug 2019 12:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38631) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3N3i-0000BF-1W for qemu-devel@nongnu.org; Thu, 29 Aug 2019 12:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3N3g-0001NP-Qn for qemu-devel@nongnu.org; Thu, 29 Aug 2019 12:14:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i3N3g-0001MU-IG for qemu-devel@nongnu.org; Thu, 29 Aug 2019 12:14:00 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3252E2A09B4; Thu, 29 Aug 2019 16:13:59 +0000 (UTC) Received: from [10.3.116.234] (ovpn-116-234.phx2.redhat.com [10.3.116.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1134C60872; Thu, 29 Aug 2019 16:13:54 +0000 (UTC) To: =?UTF-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= , Michael Roth , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <10eeadc9a86a7e3b9fa287c0389f0597f5c6a49b.1567094601.git.tgolembi@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Thu, 29 Aug 2019 11:13:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <10eeadc9a86a7e3b9fa287c0389f0597f5c6a49b.1567094601.git.tgolembi@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ip007lQlebEhnmoiYmYvJq3LEqd3GQkZW" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 29 Aug 2019 16:13:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ip007lQlebEhnmoiYmYvJq3LEqd3GQkZW Content-Type: multipart/mixed; boundary="6cLTnHJpiRqrCVS4ikMlSqKEvdwoA1xy1"; protected-headers="v1" From: Eric Blake To: =?UTF-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= , Michael Roth , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: qemu-devel@nongnu.org Message-ID: Subject: Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices References: <10eeadc9a86a7e3b9fa287c0389f0597f5c6a49b.1567094601.git.tgolembi@redhat.com> In-Reply-To: <10eeadc9a86a7e3b9fa287c0389f0597f5c6a49b.1567094601.git.tgolembi@redhat.com> --6cLTnHJpiRqrCVS4ikMlSqKEvdwoA1xy1 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/29/19 11:03 AM, Tom=C3=A1=C5=A1 Golembiovsk=C3=BD wrote: > Add command for reporting devices on Windows guest. The intent is not s= o > much to report the devices but more importantly the driver (and its > version) that is assigned to the device. >=20 > Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD > +++ b/qga/qapi-schema.json > @@ -1242,3 +1242,35 @@ > ## > { 'command': 'guest-get-osinfo', > 'returns': 'GuestOSInfo' } > + > +## > +# @GuestDeviceInfo: > +# > +# @vendor-id: vendor ID as hexadecimal string in uper case without 0x = prefix > +# @device-id: device ID as hexadecimal string in uper case without 0x = prefix s/uper/upper/ twice Should these be ints instead of strings (yes, it means they would be decimal over the wire, which is not the typical representation)? > +# @driver-name: name of the associated driver > +# @driver-date: driver release date in format MM/DD/YY Why US-centric? Better would be something like ISO, YYYY-MM-DD > +# @driver-version: driver version > +# > +# Since: 4.1.1 4.2. We don't tend to add features on stable backport branches (as this missed 4.1.0, we're unlikely to add it for 4.1.1). > +## > +{ 'struct': 'GuestDeviceInfo', > + 'data': { > + 'vendor-id': 'str', > + 'device-id': 'str', > + 'driver-name': 'str', > + 'driver-date': 'str', > + 'driver-version': 'str' > + } } > + > +## > +# @guest-get-devices: > +# > +# Retrieve information about device drivers in Windows guest > +# > +# Returns: @GuestOSInfo > +# > +# Since: 4.1.1 again, 4.2 > +## > +{ 'command': 'guest-get-devices', > + 'returns': ['GuestDeviceInfo'] } >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --6cLTnHJpiRqrCVS4ikMlSqKEvdwoA1xy1-- --ip007lQlebEhnmoiYmYvJq3LEqd3GQkZW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl1n+cEACgkQp6FrSiUn Q2oOXggAgvTOZYlyjz4QpjBxji31il+oUPzEDAkHDiyQBoWaktr0LpuaRL2tHpCe N1+ehmy1MYy5s2GbbLMuwXTwyHHaWoyjk3i2YPyhgiHJvdzH0bSjViH3j5ZNx+02 n9Lvk1VdWYIyBKx3Zk8BKkJjwiVIyIC4l8mONKgVQTdv8xINffPDQHIDDzXMQC/x /MlT0eULQjmBlarGWW7Og3BfSSs4ScKrOq3khYKqoirBRMPDgOhY0DHs4sYdpnX3 AimSqLrLbnpp3p8pfgAGmDRncupPTB1cLsKyd4dXUu09vYZVdZMvTyFg21b+x61X Zcou+zkp3evzvWdfsHVvljVzz3lRtw== =ImcG -----END PGP SIGNATURE----- --ip007lQlebEhnmoiYmYvJq3LEqd3GQkZW--