From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, yamamoto@midokura.com
Subject: Re: [RFC PATCH] linux-user: glib-ify is_proc_myself
Date: Mon, 24 May 2021 12:12:47 -0700 [thread overview]
Message-ID: <f3337919-c96f-bc13-bb89-584ec1295714@linaro.org> (raw)
In-Reply-To: <20210524112323.2310-1-alex.bennee@linaro.org>
On 5/24/21 4:23 AM, Alex Bennée wrote:
> + } else if (g_ascii_isdigit(*filename)) {
> + g_autofree char * myself = g_strdup_printf("%d/", getpid());
> + if (!g_str_has_prefix(filename, myself)) {
This seems roundabout. Wouldn't it be better to qemu_strtoul and compare the
integers?
r~
prev parent reply other threads:[~2021-05-24 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 11:23 [RFC PATCH] linux-user: glib-ify is_proc_myself Alex Bennée
2021-05-24 11:27 ` no-reply
2021-05-24 11:35 ` Daniel P. Berrangé
2021-05-24 12:35 ` Alex Bennée
2021-05-24 19:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3337919-c96f-bc13-bb89-584ec1295714@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=yamamoto@midokura.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).