From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] target/rx: Remove unused ENV_OFFSET definition
Date: Mon, 24 Jan 2022 19:24:43 +1100 [thread overview]
Message-ID: <f33b39a6-1ed9-273e-a1eb-023729893ef2@linaro.org> (raw)
In-Reply-To: <20220122002304.84016-1-f4bug@amsat.org>
On 1/22/22 11:23 AM, Philippe Mathieu-Daudé via wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/rx/cpu.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>
> typedef RXCPU ArchCPU;
>
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
> #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
> #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
> #define CPU_RESOLVING_TYPE TYPE_RX_CPU
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
For the viewers at home, the last use of ENV_OFFSET was removed in
5e1401969b25f676fee6b1c564441759cf967a43; the commit of target/rx came in just afterward.
r~
next prev parent reply other threads:[~2022-01-24 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 0:23 [PATCH] target/rx: Remove unused ENV_OFFSET definition Philippe Mathieu-Daudé via
2022-01-24 8:24 ` Richard Henderson [this message]
2022-01-24 10:14 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33b39a6-1ed9-273e-a1eb-023729893ef2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).