Re: [PATCH] target/tricore: Use unsigned types for bitops in helper_eq_b()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 23/7/24 17:10, Peter Maydell wrote:
> Coverity points out that in helper_eq_b() we have an int32_t 'msk'
> and we end up shifting into its sign bit. This is OK for QEMU because
> we use -fwrapv to give this well defined semantics, but when you look
> at what this function is doing it's doing bit operations, so we
> should be using an unsigned variable anyway. This also matches the
> return type of the function.
> 
> Make 'ret' and 'msk' uint32_t.
> 
> Resolves: Coverity CID 1547758
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target/tricore/op_helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/tricore/op_helper.c b/target/tricore/op_helper.c
> index ba9c4444b39..a0d5a0da1df 100644
> --- a/target/tricore/op_helper.c
> +++ b/target/tricore/op_helper.c
> @@ -1505,8 +1505,8 @@ uint32_t helper_sub_h(CPUTriCoreState *env, target_ulong r1, target_ulong r2)
>   
>   uint32_t helper_eq_b(target_ulong r1, target_ulong r2)
>   {
> -    int32_t ret;
> -    int32_t i, msk;
> +    uint32_t ret, msk;
> +    int32_t i;

We could even reduce 'i' scope to the for().

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>