From: Auger Eric <eric.auger@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org,
marc.zyngier@arm.com, andre.przywara@arm.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com,
alex.bennee@linaro.org, kvmarm@lists.cs.columbia.edu,
christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero
Date: Thu, 24 Nov 2016 18:31:35 +0100 [thread overview]
Message-ID: <f356b79e-efc0-342a-f14f-5926035e5145@redhat.com> (raw)
In-Reply-To: <20161124141103.yzfswsvi6ion7po5@kamzik.brq.redhat.com>
Hi Drew,
On 24/11/2016 15:11, Andrew Jones wrote:
> On Thu, Nov 24, 2016 at 10:57:01AM +0100, Auger Eric wrote:
>> Hi,
>>
>> On 23/11/2016 17:54, Andrew Jones wrote:
>>> Allow user to select who sends ipis and with which irq,
>>> rather than just always sending irq=0 from cpu0.
>>>
>>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>>
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>> Tested-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks!
>
> But if I spin a v8 then I may just dump all the command line parsing
> stuff, dropping the optional input arguments sender and irq, or at
> least irq. I'm feeling it's a bit crufty... Any thoughts on that?
Hum personally I don' have sufficient experience on this test suite to
advise. Maybe let's get inspired of the kind of tests written on x86 and
their kind of command lines. Anyway I don't want to further slow down
the pull. We will be able to refine later on when adding new tests.
Thanks
Eric
>
> drew
>
prev parent reply other threads:[~2016-11-24 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 16:53 [Qemu-devel] [kvm-unit-tests PATCH v7 00/11] arm/arm64: add gic framework Andrew Jones
2016-11-23 16:53 ` [Qemu-devel] [kvm-unit-tests PATCH v7 01/11] lib: xstr: allow multiple args Andrew Jones
2016-11-23 16:53 ` [Qemu-devel] [kvm-unit-tests PATCH v7 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit Andrew Jones
2016-11-23 16:53 ` [Qemu-devel] [kvm-unit-tests PATCH v7 03/11] arm/arm64: smp: support more than 8 cpus Andrew Jones
2016-11-23 16:53 ` [Qemu-devel] [kvm-unit-tests PATCH v7 04/11] arm/arm64: add some delay routines Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 05/11] arm/arm64: irq enable/disable Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 06/11] arm/arm64: add initial gicv2 support Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 07/11] arm/arm64: gicv2: add an IPI test Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 08/11] libcflat: add IS_ALIGNED() macro, and page sizes Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 09/11] arm/arm64: add initial gicv3 support Andrew Jones
2016-11-24 9:54 ` Auger Eric
2016-11-24 13:58 ` Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 10/11] arm/arm64: gicv3: add an IPI test Andrew Jones
2016-11-24 9:54 ` Auger Eric
2016-11-24 14:07 ` Andrew Jones
2016-11-23 16:54 ` [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero Andrew Jones
2016-11-24 9:57 ` Auger Eric
2016-11-24 14:11 ` Andrew Jones
2016-11-24 17:31 ` Auger Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f356b79e-efc0-342a-f14f-5926035e5145@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).