From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Laurent Vivier <laurent@vivier.eu>,
David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Subject: Re: [PATCH] linux-user/elfload: Fix /proc/cpuinfo features: on s390x
Date: Wed, 28 Jun 2023 09:49:18 +0200 [thread overview]
Message-ID: <f359dae7-e0a3-42cf-c2cd-fff7f9c3a607@linaro.org> (raw)
In-Reply-To: <20230627151356.273259-1-iii@linux.ibm.com>
On 6/27/23 17:13, Ilya Leoshkevich wrote:
> elf_hwcap_str() takes a bit number, but compares it for equality with
> the HWCAP_S390_* masks. This causes /proc/cpuinfo to display incorrect
> hwcaps.
>
> Fix by introducing the HWCAP_S390_NR_* constants and using them in
> elf_hwcap_str() instead of the HWCAP_S390_*. While at it, add the
> missing nnpa, pcimio and sie hwcaps from the latest kernel.
>
> Output before:
>
> features : esan3 zarch stfle msa
>
> Output after:
>
> features : esan3 zarch stfle msa ldisp eimm etf3eh highgprs vx vxe
>
> Fixes: e19807bee357 ("linux-user/elfload: Introduce elf_hwcap_str() on s390x")
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
> include/elf.h | 66 +++++++++++++++++++++++++++++++-------------
> linux-user/elfload.c | 41 ++++++++++++++-------------
> 2 files changed, 69 insertions(+), 38 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-06-28 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 15:13 [PATCH] linux-user/elfload: Fix /proc/cpuinfo features: on s390x Ilya Leoshkevich
2023-06-28 7:49 ` Richard Henderson [this message]
2023-07-14 12:16 ` [PATCH][PING] " Ilya Leoshkevich
2023-07-17 7:44 ` Richard Henderson
2023-07-17 12:31 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f359dae7-e0a3-42cf-c2cd-fff7f9c3a607@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).