From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Michael Rolnik <mrolnik@gmail.com>
Subject: Re: [PATCH] target/avr: Optimize various functions using extract opcode
Date: Sun, 3 Oct 2021 11:24:31 -0400 [thread overview]
Message-ID: <f366b3e5-cf3d-d2b7-b7ef-3ec79568a164@linaro.org> (raw)
In-Reply-To: <20211003142142.3674844-1-f4bug@amsat.org>
On 10/3/21 10:21 AM, Philippe Mathieu-Daudé wrote:
> When running the scripts/coccinelle/tcg_gen_extract.cocci
> Coccinelle semantic patch on target/avr/, we get:
>
> [DBG] candidate at target/avr/translate.c:228
> [DBG] candidate at target/avr/translate.c:266
> [DBG] candidate at target/avr/translate.c:885
> [DBG] candidate at target/avr/translate.c:924
> [DBG] candidate at target/avr/translate.c:962
>
> Manually inspect and replace combinations of (shri, andi)
> opcodes by the extract opcode.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/avr/translate.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-10-03 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 14:21 [PATCH] target/avr: Optimize various functions using extract opcode Philippe Mathieu-Daudé
2021-10-03 15:24 ` Richard Henderson [this message]
2021-10-27 4:39 ` Philippe Mathieu-Daudé
2021-10-27 9:28 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f366b3e5-cf3d-d2b7-b7ef-3ec79568a164@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).