From: Richard Henderson <richard.henderson@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, BALATON Zoltan <balaton@eik.bme.hu>,
Gerd Hoffmann <kraxel@redhat.com>,
Frederic Bezies <fredbezies@gmail.com>
Subject: Re: [PATCH] ui: Link dbus-display with pixman again
Date: Mon, 3 Jul 2023 11:29:02 +0200 [thread overview]
Message-ID: <f36e408e-3254-4336-2cee-e0f1a3db0696@linaro.org> (raw)
In-Reply-To: <CAJ+F1CKfx2i3fcikH_LujYGWmF56gyaECHqwPjwKoZqbHZsw9w@mail.gmail.com>
On 7/3/23 11:21, Marc-André Lureau wrote:
> Hi
>
> On Sat, Jul 1, 2023 at 1:49 AM Philippe Mathieu-Daudé <philmd@linaro.org
> <mailto:philmd@linaro.org>> wrote:
>
> Since its introduction in commit 142ca628a7 ("ui: add a D-Bus
> display backend"), dbus_display1 depends on pixman.
> Unfortunatly the refactor commit 1222070e77 ("meson: ensure
> dbus-display generated code is built before other units")
> dropped that dependency. Recently commit 6cc5a6159a ("ui/dbus:
> win32 support") expose this problem:
>
> In file included from include/ui/console.h:4,
> from ui/dbus.h:31,
> from ../audio/dbusaudio.c:36:
> include/ui/qemu-pixman.h:12:10: fatal error: pixman.h: No such file or directory
> 12 | #include <pixman.h>
> | ^~~~~~~~~~
>
> Restore the missing dependency on pixman.
>
>
> I fail to understand how this would help. dbus-display1 unit is pure GIO/GDBus code, no
> pixman involved. The derived library dependency is then used to build and link the dbus
> ui/ module.
meson dependencies
> - dbus_display1_lib = static_library('dbus-display1', dbus_display1, dependencies: gio)
> + dbus_display1_lib = static_library('dbus-display1', dbus_display1, dependencies:
> [gio, pixman])
like so, also include the set of -Iinclude-path-options to use when building the items
that use it. Therefore, for the moment, Phil is correct.
While dbus-display1 might not use pixman itself, ui/dbus.h certainly does.
Perhaps the usage in ui/dbus.h is the greater mistake.
r~
prev parent reply other threads:[~2023-07-03 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 23:48 [PATCH] ui: Link dbus-display with pixman again Philippe Mathieu-Daudé
2023-07-03 9:21 ` Marc-André Lureau
2023-07-03 9:29 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f36e408e-3254-4336-2cee-e0f1a3db0696@linaro.org \
--to=richard.henderson@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=fredbezies@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).