From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE10C432C0 for ; Tue, 3 Dec 2019 15:25:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C1520640 for ; Tue, 3 Dec 2019 15:25:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="XxXuOF/N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C1520640 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=greensocs.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icA3j-0006WW-5f for qemu-devel@archiver.kernel.org; Tue, 03 Dec 2019 10:25:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41275) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ic9el-00087e-4L for qemu-devel@nongnu.org; Tue, 03 Dec 2019 10:00:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ic9eg-0002mZ-Ud for qemu-devel@nongnu.org; Tue, 03 Dec 2019 10:00:00 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:41166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ic9eV-0001ld-EQ; Tue, 03 Dec 2019 09:59:48 -0500 Received: from [172.16.11.102] (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPSA id 50ED396EF0; Tue, 3 Dec 2019 14:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1575385179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tidNTzqhuJlf4WZkJ82WQRFfpo9g/npgDroo0yBSuJw=; b=XxXuOF/NU+Scg1M65uaSkqLtMoi+Ib7t4WFW9yj79G1R52BvKeeD1C+WlsXhT0+Q39EwEz Bm+NzLz/3DOLZczhtoLlBq3Dezg6FGSFKpHxLdaiOTErdc4w+YI3Cnb41DBHIDp+0iPXiU Ur+MBnfX2gWm6ZxxujmcuVxXCQZL7tU= Subject: Re: [PATCH v6 9/9] hw/arm/xilinx_zynq: connect uart clocks to slcr To: Peter Maydell References: <20190904125531.27545-1-damien.hedde@greensocs.com> <20190904125531.27545-10-damien.hedde@greensocs.com> From: Damien Hedde Message-ID: Date: Tue, 3 Dec 2019 15:59:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1575385180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tidNTzqhuJlf4WZkJ82WQRFfpo9g/npgDroo0yBSuJw=; b=XhJ2pFL27cJQ5kp/MAGV3fXwOROkxugqBglKMQNyS3/WDafmCCzXBcnt/rX68TpAGBXO6R Iy2j20qwfW04d/OXd35EAHEkLG9/KGJBL7EmgMGw/wxRU+9EsWEn+vJsdX3/DGDjAgmT9y uVxnJ8VygfmiMUbwQUcpxyhSoOuSZHo= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1575385180; a=rsa-sha256; cv=none; b=F0f1SvObNKyMvucWXfP+8kSnxjVaUqdaH3BRtZR+s44mJxCQKcWD2CeiTJ8yE7jfQuoMNb RUVW4COGCe69/hZjkZl+2HMmJj9sBd5DCPVrh6nh2cX3V8FkURi9Td5B67GLe1qGAC4uVq NXqShNHPBXntZ8vbFeWFttBBrlLcBTA= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=damien smtp.mailfrom=damien.hedde@greensocs.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , Eduardo Habkost , Alistair Francis , Mark Burton , QEMU Developers , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-arm , Paolo Bonzini , "Edgar E. Iglesias" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/2/19 4:34 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Add the connection between the slcr's output clocks and the uarts inputs. >> >> Also add the main board clock 'ps_clk', which is hard-coded to 33.33MHz >> (the default frequency). This clock is used to feed the slcr's input >> clock. >> >> Signed-off-by: Damien Hedde > > Nothing obviously wrong in the body of the patch, but as with > 7 and 8, review from a Xilinx person would be helpful. > > /* board base frequency: 33.333333 MHz */ > #define PS_CLK_FREQUENCY (100 * 1000 * 1000 / 3) > > This is interesting, because it's not an integer... I'll come back > to this topic in a reply to the cover letter in a moment. For this precise case, what I wanted is the resulting integer which I got from the device trees in linux (btw I should probably add this point in comment). Just thought it was more readable this way than "33333333". -- Damien