From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 8/8] linux-user: Log tid for strace
Date: Wed, 28 Sep 2022 22:33:50 +0200 [thread overview]
Message-ID: <f3a1797c-3efe-26f9-c19e-1e0ae05582f3@vivier.eu> (raw)
In-Reply-To: <20220829021006.67305-9-richard.henderson@linaro.org>
Le 29/08/2022 à 04:10, Richard Henderson a écrit :
> Printing the same pid for all threads isn't helpful.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/strace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index c47d91bb3d..ca9d44fa7c 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3782,7 +3782,7 @@ print_syscall(CPUArchState *cpu_env, int num,
> if (!f) {
> return;
> }
> - fprintf(f, "%d ", getpid());
> + fprintf(f, "%d ", gettid());
>
> for (i = 0; i < nsyscalls; i++) {
> if (scnames[i].nr == num) {
I've removed this patch from the PR because of a problem reported by Stefan:
cc -m64 -mcx16 -Ilibqemu-hexagon-linux-user.fa.p -I. -I..
-Itarget/hexagon -I../target/hexagon -I../common-user/host/x86_64
-I../linux-user/include/host/x86_64 -I../linux-user/include
-Ilinux-user -I../linux-user -I../linux-user/hexagon -Iqapi -Itrace
-Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto
-Wall -Winvalid-pch -Werror -std=gnu11 -O2 -g -isystem
/builds/qemu-project/qemu/linux-headers -isystem linux-headers -iquote
. -iquote /builds/qemu-project/qemu -iquote
/builds/qemu-project/qemu/include -iquote
/builds/qemu-project/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common
-fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
-Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined
-Wimplicit-fallthrough=2 -Wno-missing-include-dirs
-Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE
-isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H
'-DCONFIG_TARGET="hexagon-linux-user-config-target.h"'
'-DCONFIG_DEVICES="hexagon-linux-user-config-devices.h"' -MD -MQ
libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o -MF
libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o.d -o
libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o -c
../linux-user/strace.c
../linux-user/strace.c: In function 'print_syscall':
../linux-user/strace.c:3931:23: error: implicit declaration of
function 'gettid'; did you mean 'getgid'?
[-Werror=implicit-function-declaration]
fprintf(f, "%d ", gettid());
^~~~~~
getgid
../linux-user/strace.c:3931:23: error: nested extern declaration of
'gettid' [-Werror=nested-externs]
https://gitlab.com/qemu-project/qemu/-/jobs/3100018258
Thanks,
Laurent
next prev parent reply other threads:[~2022-09-28 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 2:09 [PATCH 0/8] linux-user: Futex improvements Richard Henderson
2022-08-29 2:09 ` [PATCH 1/8] linux-user: Combine do_futex and do_futex_time64 Richard Henderson
2022-09-27 9:48 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 2/8] linux-user: Sink call to do_safe_futex Richard Henderson
2022-09-27 9:53 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 3/8] linux-user: Implement FUTEX_WAKE_BITSET Richard Henderson
2022-09-27 9:54 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 4/8] linux-user: Convert signal number for FUTEX_FD Richard Henderson
2022-09-27 9:56 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 5/8] linux-user: Implement PI futexes Richard Henderson
2022-09-27 10:29 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 6/8] linux-user: Update print_futex_op Richard Henderson
2022-09-27 10:31 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 7/8] linux-user: Lock log around strace Richard Henderson
2022-09-27 10:33 ` Laurent Vivier
2022-08-29 2:10 ` [PATCH 8/8] linux-user: Log tid for strace Richard Henderson
2022-09-27 10:34 ` Laurent Vivier
2022-09-28 20:33 ` Laurent Vivier [this message]
2022-09-27 10:59 ` [PATCH 0/8] linux-user: Futex improvements Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a1797c-3efe-26f9-c19e-1e0ae05582f3@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).