From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1268C2B9F4 for ; Tue, 22 Jun 2021 08:21:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96FA260C3E for ; Tue, 22 Jun 2021 08:21:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96FA260C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvbeX-0007Do-Pq for qemu-devel@archiver.kernel.org; Tue, 22 Jun 2021 04:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvbdq-0006FE-6m for qemu-devel@nongnu.org; Tue, 22 Jun 2021 04:20:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvbdo-0003MR-3k for qemu-devel@nongnu.org; Tue, 22 Jun 2021 04:20:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624350015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OJfG6xHzKZO4p1mF7QOoq2I//Jjw6HTCsW5K0iOYu3Q=; b=bWCturH/RemvZdq/128m6Zp/BQ83a2JodnjwOcsIne+vQB9OzfvdCxCv5yVF624EQJPgXy XrN7bbIVsU1N5E87XwaDhLH3qpl4uuzq+zk5EPnY2KrkgmUO20iLqENXsvfKF5efpoRvnV zY3oaduJl50tg/vzPkvDA3vfPFbX5Tg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-W4Fet5gtORmgcklIl2dBmA-1; Tue, 22 Jun 2021 04:20:13 -0400 X-MC-Unique: W4Fet5gtORmgcklIl2dBmA-1 Received: by mail-wm1-f70.google.com with SMTP id j2-20020a05600c1c02b02901cecbe55d49so1979391wms.3 for ; Tue, 22 Jun 2021 01:20:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OJfG6xHzKZO4p1mF7QOoq2I//Jjw6HTCsW5K0iOYu3Q=; b=cA1vfcYewL089S2xB2n9C9ubHYI/cszhAYAz0DXWMWGbBLX9P4MEFgI0SyUS6kH2Yq p0h7IrEtQ8AsEWDuKVjF3GH+LzFG6yxVrDh38EP3U962/U/Pum2E/9hEb1XJoEljYDWN 95MoFN0uZToX69JoNgGH4ENN63Mr+w7T1NaA/0mzyemrnS09dESRBHP4iclzDOkG0A8y y3t5NYUQNeulZ/j0vd5H5znJoIanpSlilNnHNEw4Q9Uaw4RbS9lBHhkfjwHKsolpeRV9 NKYqT3wRbB9rSsWPDcRzhkZ0Z2Bch+TVe76nLkQyyghvttPmj8RuHMVWbpcSgb6bpXeQ 6cXQ== X-Gm-Message-State: AOAM530C/bT1hUjLB0LYNR0keFqE8f+lup7CP6i0DuVvoKGlmLzeJSYY T1HXPor0pvApylm+g9XfWh6H+U0oYxvs5VQg7ZTzSv4jdb05cjIlhmpPWc2UzIjjRxKtBZKLEFw mbBlXmKy9W6F6q2A= X-Received: by 2002:a05:600c:210:: with SMTP id 16mr3132903wmi.59.1624350010698; Tue, 22 Jun 2021 01:20:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2PJTrOw0/UpmCYlo5yV0NhXx9YkeWSPxa8hLrhoFKaWFZR1TI6gHTTX1IO+TQabBH+ikPog== X-Received: by 2002:a05:600c:210:: with SMTP id 16mr3132869wmi.59.1624350010385; Tue, 22 Jun 2021 01:20:10 -0700 (PDT) Received: from [192.168.43.95] ([37.173.9.63]) by smtp.gmail.com with ESMTPSA id z6sm16031414wrh.65.2021.06.22.01.20.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 01:20:09 -0700 (PDT) Subject: Re: QEMU PCIe expander bridge with 64kB page guest -> guest BUG_ON() From: Eric Auger To: qemu list , qemu-arm , Ard Biesheuvel , Xingang Wang , miaoyubo@huawei.com References: <1811f735-3426-08c0-ee86-b410b632efb5@redhat.com> Message-ID: Date: Tue, 22 Jun 2021 10:20:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1811f735-3426-08c0-ee86-b410b632efb5@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eauger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eauger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.373, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Adding Yubo in the loop as Jiahui's address is bouncing. On 6/21/21 6:22 PM, Eric Auger wrote: > Hi Jiahui, > > I noticed the PCIe expander bridge + PCIe root port does not work with a > 64kB page guest. One hits a kernel BUG at mm/vmalloc.c:96 > (BUG_ON(!pte_none(*pte));)! This happens with an upstream guest. > > I understand this happens on pci_remap_iospace when handling the Io16 > regions below. Wonder if the edk2 code could be the source (I saw you > write both the edk2 and the qemu part [edk2-devel] [PATCH v2 0/4] Add > extra pci roots support for Arm). > > Please could give me a hand? > > Best Regards > > Eric > > > Sample qemu cmd options: > > -device pxb-pcie,bus_nr=4,id=bridge,bus=pcie.0 \ > -device pcie-root-port,bus=bridge,chassis=4,id=pcie.11 \ > -device virtio-net-pci,bus=pcie.11,netdev=nic0,mac=6a:f5:10:b1:3d:d2 > -netdev > tap,id=nic0,script=/home/augere/TEST/SCRIPTS/qemu-ifup,downscript=/home/augere/TEST/SCRIPTS/qemu-ifdown > > > [ 2.867734] ACPI: PCI Root Bridge [PCFE] (domain 0000 [bus fe-ff]) > [ 2.869339] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM > ClockPM Segments MSI EDR HPX-Type3] > [ 2.871405] acpi PNP0A08:00: _OSC: platform does not support [LTR DPC] > [ 2.873226] acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME > AER PCIeCapability] > [ 2.875609] acpi PNP0A08:00: ECAM area [mem > 0x401fe00000-0x401fffffff] reserved by PNP0C02:00 > [ 2.877830] acpi PNP0A08:00: ECAM at [mem 0x401fe00000-0x401fffffff] > for [bus fe-ff] > phys_addr=0x3eff3000 > [ 2.884036] ------------[ cut here ]------------ > [ 2.885249] kernel BUG at mm/vmalloc.c:96! > [ 2.886322] Internal error: Oops - BUG: 0 [#1] SMP > [ 2.887560] Modules linked in: > [ 2.888352] CPU: 7 PID: 1 Comm: swapper/0 Not tainted > 5.13.0-rc6-guest-64K+ #57 > [ 2.890216] Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 > 02/06/2015 > [ 2.891983] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO BTYPE=--) > [ 2.893519] pc : vmap_range+0x1d8/0x208 > [ 2.894600] lr : vmap_range+0x38/0x208 > [ 2.895615] sp : fffffe0012c2f7f0 > [ 2.896517] x29: fffffe0012c2f7f0 x28: fffffffefe800000 x27: > fffffffefe801000 > [ 2.898437] x26: ffffffff20070000 x25: 00000001407f0000 x24: > 0140000000000000 > [ 2.900357] x23: fffffe001134ffb8 x22: 000000000000003f x21: > 0068000000000717 > [ 2.902284] x20: 000000003eff3000 x19: fffffffefe801000 x18: > 0000000000000010 > [ 2.904236] x17: 0000000000000000 x16: 0000000000000001 x15: > ffffffffffffffff > [ 2.906157] x14: 695f70616d65725f x13: 696370202a2a2a2a x12: > fffffe0011c77150 > [ 2.908084] x11: 0000000000000003 x10: fffffe0011bb7110 x9 : > fffffe0010d33ad4 > [ 2.909996] x8 : 00000000000bffe8 x7 : c0000000ffff7fff x6 : > 0000000000000001 > [ 2.911323] x5 : 0000000000000000 x4 : 000000003eff0000 x3 : > 0000000000001ff7 > [ 2.912631] x2 : 0040000000000001 x1 : fffffc07f4080038 x0 : > fffffc07ffbecdc0 > [ 2.913951] Call trace: > [ 2.914398] vmap_range+0x1d8/0x208 > [ 2.915363] ioremap_page_range+0x20/0x30 > [ 2.916453] pci_remap_iospace+0xcc/0xf0 > [ 2.917519] acpi_pci_probe_root_resources+0x244/0x268 > [ 2.918907] pci_acpi_root_prepare_resources+0x28/0xc8 > [ 2.920281] acpi_pci_root_create+0x9c/0x2f8 > [ 2.921443] pci_acpi_scan_root+0x14c/0x230 > [ 2.922574] acpi_pci_root_add+0x268/0x5c0 > [ 2.923710] acpi_bus_attach+0x15c/0x2c0 > [ 2.924794] acpi_bus_attach+0x9c/0x2c0 > [ 2.925833] acpi_bus_attach+0x9c/0x2c0 > [ 2.926881] acpi_bus_scan+0x64/0x118 > [ 2.927875] acpi_scan_init+0x10c/0x25c > [ 2.928922] acpi_init+0x3e8/0x458 > [ 2.929847] do_one_initcall+0x54/0x268 > [ 2.930879] kernel_init_freeable+0x290/0x344 > [ 2.932068] kernel_init+0x1c/0x128 > [ 2.933017] ret_from_fork+0x10/0x18 > [ 2.934005] Code: a90687e2 97f518e5 a94687e2 17ffffe4 (d4210000) > [ 2.935673] ---[ end trace 1d687ce361e3e7ca ]--- > [ 2.936922] Kernel panic - not syncing: Oops - BUG: Fatal exception > [ 2.938611] SMP: stopping secondary CPUs > [ 2.939760] ---[ end Kernel panic - not syncing: Oops - BUG: Fatal > exception ]--- > > > At EDK2 level I have: > > PciBus: Resource Map for Root Bridge PciRoot(0x0)^M > Type = Io16; Base = 0x0; Length = 0x3000; Alignment = 0xFFF^M > Base = 0x0; Length = 0x200; Alignment = 0xFFF; Owner = PPB > [00|02|02:**]^M > Base = 0x1000; Length = 0x200; Alignment = 0xFFF; Owner = > PPB [00|02|01:**]^M > Base = 0x2000; Length = 0x200; Alignment = 0xFFF; Owner = > PPB [00|02|00:**]^M > Type = Mem32; Base = 0x10000000; Length = 0x700000; > Alignment = 0x1FFFFF^M > Base = 0x10000000; Length = 0x200000; Alignment = 0x1FFFFF; > Owner = PPB [00|02|02:**]^M > Base = 0x10200000; Length = 0x200000; Alignment = 0x1FFFFF; > Owner = PPB [00|02|01:**]^M > Base = 0x10400000; Length = 0x200000; Alignment = 0x1FFFFF; > Owner = PPB [00|02|00:**]^M > Base = 0x10600000; Length = 0x1000; Alignment = 0xFFF; > Owner = PPB [00|02|02:10]^M > Base = 0x10601000; Length = 0x1000; Alignment = 0xFFF; > Owner = PPB [00|02|01:10]^M > Base = 0x10602000; Length = 0x1000; Alignment = 0xFFF; > Owner = PPB [00|02|00:10]^M > Type = Mem64; Base = 0x8000000000; Length = 0x200000; > Alignment = 0xFFFFF^M > Base = 0x8000000000; Length = 0x100000; Alignment = 0xFFFFF; > Owner = PPB [00|02|01:**]; Type = PMem64^M > Base = 0x8000100000; Length = 0x100000; Alignment = 0xFFFFF; > Owner = PPB [00|02|02:**]; Type = PMem64^M > > > PciBus: Resource Map for Root Bridge PciRoot(0x4)^M > Type = Io16; Base = 0x3000; Length = 0x1000; Alignment = 0xFFF^M > Base = 0x3000; Length = 0x200; Alignment = 0xFFF; Owner = > PPB [04|00|00:**]^M > Type = Mem32; Base = 0x10800000; Length = 0x300000; > Alignment = 0x1FFFFF^M > Base = 0x10800000; Length = 0x200000; Alignment = 0x1FFFFF; > Owner = PPB [04|00|00:**]^M > Base = 0x10A00000; Length = 0x1000; Alignment = 0xFFF; > Owner = PPB [04|00|00:10]^M > ^M > PciBus: Resource Map for Bridge [04|00|00]^M > Type = Io16; Base = 0x3000; Length = 0x200; Alignment = 0xFFF^M > Base = Padding; Length = 0x200; Alignment = 0x1FF^M > Type = Mem32; Base = 0x10800000; Length = 0x200000; > Alignment = 0x1FFFFF^M > Base = Padding; Length = 0x200000; Alignment = 0x1FFFFF^M > Type = Mem32; Base = 0x10A00000; Length = 0x1000; > Alignment = 0xFFF^M >