From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85A6CC87FD1 for ; Tue, 5 Aug 2025 05:10:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uj9w2-0003Rd-TF; Tue, 05 Aug 2025 01:10:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uj9vr-0003Ou-AZ for qemu-devel@nongnu.org; Tue, 05 Aug 2025 01:09:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uj9vn-00069u-Lc for qemu-devel@nongnu.org; Tue, 05 Aug 2025 01:09:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754370585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=loY19w4tQtc2JSJ9o5IjQUduUtn1Eruq1YAWJw1TDgE=; b=eHPmeAr57lInkClg21VDjDvbMDojx8O2vq7EeYXRfljNQr9a6nRWbUXtBB5HJYgA3rqmMK 6Jcv6rA3sWf8CQJo1W3wO7frYhY+uXjgavS3utFaYqLy6njw9mvCzsJ0UDHuukQpsOmpXB PaxBRbIszKe+ajt3dyrX5SYl8XAJ8Fc= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-Lu1RHk5GPima7f4silCDiA-1; Tue, 05 Aug 2025 01:09:44 -0400 X-MC-Unique: Lu1RHk5GPima7f4silCDiA-1 X-Mimecast-MFC-AGG-ID: Lu1RHk5GPima7f4silCDiA_1754370584 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-7073cc86450so58701756d6.2 for ; Mon, 04 Aug 2025 22:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754370583; x=1754975383; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=loY19w4tQtc2JSJ9o5IjQUduUtn1Eruq1YAWJw1TDgE=; b=WOPhKVxqOJxLRqj5FDihsyV8iZURKR2uHMiiazPMEouePex7yPB2NIqQCx4AqCF6Bg pahNDM3wpEWe+5iUw8nhaAFbgyFcdenKHL3z3LXEt2E3T2Wy4XdwSNoe7PbviP3fG19i q6xqsiDkwmLC6HBvFP3rb3JSo7wkhfAXrmHEaydJrFqJIAWyon1THa+RHNYNP1qOzD5V 8cDueK/CJYUm4/25Qxh/7ofrUlA1QqwssOpYSmawVrzFZ5iUgRsRVLjZQj0WKxr6YM6F T2WITVBSeezyPRUB+g8f7U0f9PLf7w9hemRbVh6U+MuqAdK37tP4OAXAo4F8Ba8R5O5G p3aA== X-Gm-Message-State: AOJu0YyfE1gNprYX4OHSMI/8g8zxWqCyruo+wRlhBZNf7PuMER6pit1P XErGMOtLrTWbJvmtE1ak0Mhb+JE9bVv2eq4qoj8dMlNB1zSC76XPBCnQvLyrfoxj06P/qS/Bhwn q4zn0FBUVwnQQVtdPwc5StQmetObAtNnTDNXsCWQVw6hoSHEJtnykuitB X-Gm-Gg: ASbGncs81sbu5AifqPCXyFvIOgbw6/rnZO9KLWWUX29rupMy9ioK4Pe2zVDRHCm7QEM vQyFInA+KJjrvCXSTxw5mc2yzXKC0UVDTyx68QaDlDMWBNYHslky05GX55HlHDw+cEDcUTLycrr 4Na1g5joDen6zpk/tuy/PehYHlPeldY7mnl2ggBbruV0ZFalmgW6wla0at68BRMFLMYVsCNF2ZC 2eEZI/5/vGdkbn+u3j0o32efldZVvi4ReI8UzSnmsNeAeDzfJqglUT7UzxWrotfjHUiB+hd9Uu9 c5cjBpOSowKiww2AUTYye90uc4aBdxkSYyGhB2dJWgIX06O23yfU1yLdzKPxjIB7XjtD2OuGeO9 Oog== X-Received: by 2002:a05:6214:400b:b0:707:430e:dc00 with SMTP id 6a1803df08f44-70936317844mr194800306d6.39.1754370583485; Mon, 04 Aug 2025 22:09:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFK+ZN0Gwos6S3pdl7we6GC6y8pR1tU3i6cx3GKLv0tubLy8fZ2egK0aufTb4VyfzJfbGqxHw== X-Received: by 2002:a05:6214:400b:b0:707:430e:dc00 with SMTP id 6a1803df08f44-70936317844mr194799946d6.39.1754370582535; Mon, 04 Aug 2025 22:09:42 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077c9d894bsm65399566d6.11.2025.08.04.22.09.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 22:09:42 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2025 07:09:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/50] ppc/xive: updates for PowerVM To: milesg@linux.ibm.com, Nicholas Piggin , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= , Michael Kowal , Caleb Schlossin , Harsh Prateek Bora References: <20250512031100.439842-1-npiggin@gmail.com> <56c95bf5-45bd-43c0-a6ca-62845b2bdca6@redhat.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Glenn, +Harsh On 8/4/25 19:37, Miles Glenn wrote: > On Sun, 2025-07-20 at 23:26 +0200, Cédric Le Goater wrote: >> On 5/16/25 03:29, Nicholas Piggin wrote: >>> On Fri May 16, 2025 at 1:36 AM AEST, Cédric Le Goater wrote: >>>> On 5/12/25 05:10, Nicholas Piggin wrote: >>>>> These changes gets the powernv xive2 to the point it is able to run >>>>> PowerVM with good stability. >>>>> >>>>> * Various bug fixes around lost interrupts particularly. >>>>> * Major group interrupt work, in particular around redistributing >>>>> interrupts. Upstream group support is not in a complete or usable >>>>> state as it is. >>>>> * Significant context push/pull improvements, particularly pool and >>>>> phys context handling was quite incomplete beyond trivial OPAL >>>>> case that pushes at boot. >>>>> * Improved tracing and checking for unimp and guest error situations. >>>>> * Various other missing feature support. >>>>> >>>>> The ordering and grouping of patches in the series is not perfect, >>>>> because it had been an ongoing development, and PowerVM only started >>>>> to become stable toward the end. I did try to rearrange and improve >>>>> things, but some were not worth rebasing cost (e.g., some of the >>>>> pool/phys pull redistribution patches should have ideally been squashed >>>>> or moved together), so please bear that in mind. Suggestions for >>>>> further rearranging the series are fine, but I might just find they are >>>>> too much effort to be worthwhile. >>>>> >>>>> Thanks, >>>>> Nick >>>>> >>>>> Glenn Miles (12): >>>>> ppc/xive2: Fix calculation of END queue sizes >>>>> ppc/xive2: Use fair irq target search algorithm >>>>> ppc/xive2: Fix irq preempted by lower priority group irq >>>>> ppc/xive2: Fix treatment of PIPR in CPPR update >>>>> pnv/xive2: Support ESB Escalation >>>>> ppc/xive2: add interrupt priority configuration flags >>>>> ppc/xive2: Support redistribution of group interrupts >>>>> ppc/xive: Add more interrupt notification tracing >>>>> ppc/xive2: Improve pool regs variable name >>>>> ppc/xive2: Implement "Ack OS IRQ to even report line" TIMA op >>>>> ppc/xive2: Redistribute group interrupt precluded by CPPR update >>>>> ppc/xive2: redistribute irqs for pool and phys ctx pull >>>>> >>>>> Michael Kowal (4): >>>>> ppc/xive2: Remote VSDs need to match on forwarding address >>>>> ppc/xive2: Reset Generation Flipped bit on END Cache Watch >>>>> pnv/xive2: Print value in invalid register write logging >>>>> pnv/xive2: Permit valid writes to VC/PC Flush Control registers >>>>> >>>>> Nicholas Piggin (34): >>>>> ppc/xive: Fix xive trace event output >>>>> ppc/xive: Report access size in XIVE TM operation error logs >>>>> ppc/xive2: fix context push calculation of IPB priority >>>>> ppc/xive: Fix PHYS NSR ring matching >>>>> ppc/xive2: Do not present group interrupt on OS-push if precluded by >>>>> CPPR >>>>> ppc/xive2: Set CPPR delivery should account for group priority >>>>> ppc/xive: tctx_notify should clear the precluded interrupt >>>>> ppc/xive: Explicitly zero NSR after accepting >>>>> ppc/xive: Move NSR decoding into helper functions >>>>> ppc/xive: Fix pulling pool and phys contexts >>>>> pnv/xive2: VC_ENDC_WATCH_SPEC regs should read back WATCH_FULL >>>>> ppc/xive: Change presenter .match_nvt to match not present >>>>> ppc/xive2: Redistribute group interrupt preempted by higher priority >>>>> interrupt >>>>> ppc/xive: Add xive_tctx_pipr_present() to present new interrupt >>>>> ppc/xive: Fix high prio group interrupt being preempted by low prio VP >>>>> ppc/xive: Split xive recompute from IPB function >>>>> ppc/xive: tctx signaling registers rework >>>>> ppc/xive: tctx_accept only lower irq line if an interrupt was >>>>> presented >>>>> ppc/xive: Add xive_tctx_pipr_set() helper function >>>>> ppc/xive2: split tctx presentation processing from set CPPR >>>>> ppc/xive2: Consolidate presentation processing in context push >>>>> ppc/xive2: Avoid needless interrupt re-check on CPPR set >>>>> ppc/xive: Assert group interrupts were redistributed >>>>> ppc/xive2: implement NVP context save restore for POOL ring >>>>> ppc/xive2: Prevent pulling of pool context losing phys interrupt >>>>> ppc/xive: Redistribute phys after pulling of pool context >>>>> ppc/xive: Check TIMA operations validity >>>>> ppc/xive2: Implement pool context push TIMA op >>>>> ppc/xive2: redistribute group interrupts on context push >>>>> ppc/xive2: Implement set_os_pending TIMA op >>>>> ppc/xive2: Implement POOL LGS push TIMA op >>>>> ppc/xive2: Implement PHYS ring VP push TIMA op >>>>> ppc/xive: Split need_resend into restore_nvp >>>>> ppc/xive2: Enable lower level contexts on VP push >>>>> >>>>> hw/intc/pnv_xive.c | 16 +- >>>>> hw/intc/pnv_xive2.c | 139 +++++-- >>>>> hw/intc/pnv_xive2_regs.h | 1 + >>>>> hw/intc/spapr_xive.c | 18 +- >>>>> hw/intc/trace-events | 12 +- >>>>> hw/intc/xive.c | 555 ++++++++++++++++++---------- >>>>> hw/intc/xive2.c | 717 +++++++++++++++++++++++++++--------- >>>>> hw/ppc/pnv.c | 48 +-- >>>>> hw/ppc/spapr.c | 21 +- >>>>> include/hw/ppc/xive.h | 66 +++- >>>>> include/hw/ppc/xive2.h | 22 +- >>>>> include/hw/ppc/xive2_regs.h | 22 +- >>>>> 12 files changed, 1145 insertions(+), 492 deletions(-) >>>>> >>>> >>>> I am impressed :) and glad that you are still taking care of XIVE. >>>> >>>> I suggest adding new names under the XIVE entry in the MAINTAINERS file. >>> >>> Yeah it's good to see. They are building a lot more cool stuff with >>> powernv at the moment, hopefully almost all should get upstreamed >>> eventually. >>> >>> I will try to convince them to add MAINTAINER entries :) >>> >>> Thanks, >>> Nick >>> >> >> This is a major update for XIVE and, since I am not sure anyone >> is going to send a PR for QEMU 10.1, I am volunteering to do >> it again on monday, once and only for these fixes. >> >> We should clarify in the next cycle who is charge of ppc. IMO, >> If we don't have maintainers, we should orphan all non-pseries >> PPC components. I can send a maintainer update on this as soon >> as the QEMU 10.2 cycle opens. >> >> >> Thanks, >> >> C. >> > > Cédric, > > Thanks for doing the PR for these XIVE changes! It sounds like if we > want to continue having our XIVE changes upstreamed we will need > someone on our IBM QEMU development team to volunteer as a maintainer. We did some updates recently : https://lore.kernel.org/qemu-devel/20250724133126.1695824-1-clg@redhat.com/ Given your knowledge of IBM Power servers, your relationships with the hardware team, and the quality of your work within QEMU, you should add your self as a Reviewer of PowerNV and XIVE (Needs a Maintainer also). I can merge that for QEMU 10.1. > Does becoming a maintainer still require physically attending a key > signing party at KVM Forum? To be able to send PRs, it is strongly recommended to have your key signed by the people pulling in your changes. Being physically present is always better to verify the identity of a person. But that's not all, it's a chain of trust and a community involvement in all areas. It takes time. Btw, in series [1], there are several patches tagged as Fixes, could you please reply to Michael [2] regarding which could be backported to the stable branches ? Thanks, C. [1] https://lore.kernel.org/qemu-devel/20250512031100.439842-1-npiggin@gmail.com/ [2] https://lore.kernel.org/qemu-devel/10177005-d549-41bc-b0eb-c98b7e475f97@tls.msk.ru/