From: Thomas Huth <thuth@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH] CHANGELOG: remove disused file
Date: Mon, 26 Oct 2020 16:49:52 +0100 [thread overview]
Message-ID: <f3b1f8ce-367b-c740-ebcd-2bce425d8d81@redhat.com> (raw)
In-Reply-To: <35df91c4-49e5-bc9e-e153-a27b7f443ffd@redhat.com>
On 26/10/2020 16.21, John Snow wrote:
> On 10/23/20 2:51 PM, Thomas Huth wrote:
>> On 23/10/2020 18.34, John Snow wrote:
>>> On 10/23/20 1:43 AM, Thomas Huth wrote:
>>>> On 22/10/2020 18.28, John Snow wrote:
>>>>> There's no reason to keep this here; the versions described are
>>>>> ancient. Everything here is still mirrored on
>>>>> https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use
>>>>> the git history.
>>>>>
>>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>>> ---
>>>>> Changelog | 580 ------------------------------------------------------
>>>>> 1 file changed, 580 deletions(-)
>>>>> delete mode 100644 Changelog
>>>>>
>>>>> diff --git a/Changelog b/Changelog
>>>>> deleted file mode 100644
>>>>> index f7e178ccc01..00000000000
>>>>> --- a/Changelog
>>>>> +++ /dev/null
>>>>> @@ -1,580 +0,0 @@
>>>>> -This file documents changes for QEMU releases 0.12 and earlier.
>>>>> -For changelog information for later releases, see
>>>>> -https://wiki.qemu.org/ChangeLog or look at the git history for
>>>>> -more detailed information.
>>>>
>>>> I agree with removing the old log. But should we maybe leave a pointer to
>>>> https://wiki.qemu.org/ChangeLog / the git history here to let people know
>>>> how to see the changelogs?
>>>>
>>>> Thomas
>>>>
>>>
>>> Maybe in README.rst, just below "Bug Reporting" and above "Contact" ?
>>>
>>>
>>> Changelog
>>> =========
>>>
>>> For version history and release notes, please visit
>>> `<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for more
>>> detailed information.
>>
>> Ok, but IIRC the "ChangeLog" file is a standard file in GNU coding
>> conventions, so it might be worth to keep the information in this file ...
>> of course we are not bound to the GNU conventions in QEMU, but users still
>> might expect to find the information in here...
>>
>> Thomas
>>
>
> My point in removing it is just getting rid of the runaround. If we don't
> have the changelog information in CHANGELOG, why have the file and pretend
> like we do?
>
> Moving it into README.rst makes it visible on github and gitlab to people
> stopping by for the first time.
Ok, fair point.
Thomas
prev parent reply other threads:[~2020-10-26 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 16:28 [PATCH] CHANGELOG: remove disused file John Snow
2020-10-22 16:40 ` Daniel P. Berrangé
2020-10-23 5:43 ` Thomas Huth
2020-10-23 16:34 ` John Snow
2020-10-23 18:51 ` Thomas Huth
2020-10-26 11:05 ` Paolo Bonzini
2020-10-26 15:21 ` John Snow
2020-10-26 15:44 ` Peter Maydell
2020-10-26 15:49 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b1f8ce-367b-c740-ebcd-2bce425d8d81@redhat.com \
--to=thuth@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).