From: Eric Blake <eblake@redhat.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] editorconfig: set emacs mode
Date: Mon, 20 Aug 2018 14:51:03 -0500 [thread overview]
Message-ID: <f3bc790e-bcc2-5273-7825-313f2a72f168@redhat.com> (raw)
In-Reply-To: <CAFEAcA_hyByeMb5fK88nHO2JVc9CkWc-sYQDjYoh9MfqHJnF5w@mail.gmail.com>
On 08/20/2018 01:00 PM, Peter Maydell wrote:
> On 20 August 2018 at 18:43, Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
>> Some time ago, I proposed to use an (eval) in .dir-locals.el to set
>> the mode for all json files and Makefile. Unfortunately, this isn't
>> safe, and emacs will prompt the user, which isn't very friendly.
>>
>> Fortunately, editorconfig provides a special config key which does
>> allow to set the emacs mode. Set the emacs mode for JSON, GLSL and
>> extra makefiles that are not yet covered. Drop modeline from JSON
>> files.
>
> Does emacs apply info from the the editorconfig file by default, though?
Per https://editorconfig.org/, no, you have to first install an emacs
plugin to get editorconfig files to have any effect. So this patch is a
non-starter unless distros start patching emacs to install that plugin
by default.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-08-20 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 17:43 [Qemu-devel] [PATCH] editorconfig: set emacs mode Marc-André Lureau
2018-08-20 18:00 ` Peter Maydell
2018-08-20 19:51 ` Eric Blake [this message]
2018-08-20 20:49 ` Marc-André Lureau
2018-08-21 5:26 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3bc790e-bcc2-5273-7825-313f2a72f168@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).