From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxbFR-0005hA-DQ for qemu-devel@nongnu.org; Mon, 10 Apr 2017 11:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxbFM-0002bE-Lr for qemu-devel@nongnu.org; Mon, 10 Apr 2017 11:28:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cxbFM-0002a3-G4 for qemu-devel@nongnu.org; Mon, 10 Apr 2017 11:28:52 -0400 References: <20170410150350.3267-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Mon, 10 Apr 2017 17:28:44 +0200 MIME-Version: 1.0 In-Reply-To: <20170410150350.3267-1-ard.biesheuvel@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] hw/acpi-defs: replace leading X with x_ in FADT field names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ard Biesheuvel , qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: phil@philjordan.eu, mst@redhat.com, imammedo@redhat.com, drjones@redhat.com, zhaoshenglong@huawei.com On 04/10/17 17:03, Ard Biesheuvel wrote: > At the request of Michael, replace the leading capital X in the FADT > field name Xfacs and Xdsdt with lower case x + underscore. > > Cc: Michael S. Tsirkin > Signed-off-by: Ard Biesheuvel > --- > include/hw/acpi/acpi-defs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index 4cc3630e613e..db48807056b3 100644 > --- a/include/hw/acpi/acpi-defs.h > +++ b/include/hw/acpi/acpi-defs.h > @@ -165,8 +165,8 @@ struct AcpiFadtDescriptorRev5_1 { > /* ARM-Specific Boot Flags (see below for individual flags) (ACPI 5.1) */ > uint16_t arm_boot_flags; > uint8_t minor_revision; /* FADT Minor Revision (ACPI 5.1) */ > - uint64_t Xfacs; /* 64-bit physical address of FACS */ > - uint64_t Xdsdt; /* 64-bit physical address of DSDT */ > + uint64_t x_facs; /* 64-bit physical address of FACS */ > + uint64_t x_dsdt; /* 64-bit physical address of DSDT */ > /* 64-bit Extended Power Mgt 1a Event Reg Blk address */ > struct AcpiGenericAddress xpm1a_event_block; > /* 64-bit Extended Power Mgt 1b Event Reg Blk address */ > (This is for 2.10, or whatever comes after 2.9.) Reviewed-by: Laszlo Ersek