From: Richard Henderson <richard.henderson@linaro.org>
To: Nathan Ringo <nathan@remexre.xyz>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH v2] This makes it easier to figure out whether a particular instruction was actually translated.
Date: Fri, 7 May 2021 16:24:31 -0700 [thread overview]
Message-ID: <f3e79a92-802d-b9d0-048a-cf8d80309388@linaro.org> (raw)
In-Reply-To: <FITkUaiC5DeyCU3e1T6EisgkkQ8Fnrwf2WZTBGE@cp4-web-031.plabs.ch>
On 5/7/21 3:48 PM, Nathan Ringo wrote:
> - trace_translate_block(tb, tb->pc, tb->tc.ptr);
> + trace_translate_block(tb, tb->pc, (int)tb->icount, tb->tc.ptr);
What target are you looking at, because for the variable-length isa's,
instruction count may not really help. Perhaps tb->size instead?
r~
next prev parent reply other threads:[~2021-05-07 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 22:48 [PATCH v2] This makes it easier to figure out whether a particular instruction was actually translated Nathan Ringo
2021-05-07 23:24 ` Richard Henderson [this message]
2021-05-09 1:57 ` Nathan Ringo
2021-05-09 18:15 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e79a92-802d-b9d0-048a-cf8d80309388@linaro.org \
--to=richard.henderson@linaro.org \
--cc=nathan@remexre.xyz \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).