From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1948DC433ED for ; Fri, 7 May 2021 23:25:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8495C61157 for ; Fri, 7 May 2021 23:25:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8495C61157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf9qh-00008a-Fq for qemu-devel@archiver.kernel.org; Fri, 07 May 2021 19:25:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf9pl-0007is-E4 for qemu-devel@nongnu.org; Fri, 07 May 2021 19:24:37 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:43938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf9pj-00053i-CU for qemu-devel@nongnu.org; Fri, 07 May 2021 19:24:37 -0400 Received: by mail-pl1-x634.google.com with SMTP id v20so6026632plo.10 for ; Fri, 07 May 2021 16:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=xhFQIBPZ0mRG9+1aWL5Nht7pW/htDX8x/00VxhXpWmg=; b=efa2BQ68++KOfibMp417BuLDf/gp79ETW3O+fpBp/N1BE8pwgUTSd1wVuSgq9HH0KA IG6RmcwxzKjbDZ3axi1n0NFm0aQNO3Q+nysBmqYHxO/+xBQ986sfTNMIS1kfBO4tTz6L AQESxXTfcXbBrbFMbf+/KqJ2pCf9vjr2AkPPaNMqn/s9ke2/SQrHRAyfWwTeEo+PvPZ+ TB5qhz3QLNaqY/Y03mANP6FRTz1GiVyfKkpOriRzPWLxKfQekP3VxFnWCoqXVZNZ1HIU 3TXo0yDqDKpcMqs0nBtIWxIZ4fkKCi6eNHkL9o/y4U5JIB7tnhXq+34fjWDKEXseUn7i oeaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xhFQIBPZ0mRG9+1aWL5Nht7pW/htDX8x/00VxhXpWmg=; b=ENYIJm9rpXQo7ATa6xe1J6fm/KcYo+7E3CivPyuQnMwtKdjwl4uEjJK68zmFKD/s0i 53wyydb11r41YiQuDDUbsW3es3LgEnX4v0I5zIup2BALHBV4aJAkx5l0IixDhzIiJQQF iGdpzATCmHy9V71nnEItFlnaO8Y54FXBkLbRlXD3Do+/qFDzBQiyV2UknjfqAfTZosrb qDUIQJkBn7/PvK8WAN454k5nBamLSQ/kdznFdORdUXkvluA2DTWdLW2RA2u8cjeVUgeM 8SvmF3TmBJ86bsmY2VLikrQirJ+QoV4+qWX1GPmNsfclNz9v+soR/9vpP01qQ8kf9Xcv M7ww== X-Gm-Message-State: AOAM532+3E2zts3DC7zsFClAGHBnPiU89RODn8iBF0V1JrOKTfW2CnH+ 8h3Kp5Vk1KqL3GN1IkRQy+VoXg== X-Google-Smtp-Source: ABdhPJzrMQimvxaEBvpii5d5tzRHGYDU+pQcTtlLZ+H3HPtqLTJu5SFEK2GUWegqfu+mJaPGXLZttw== X-Received: by 2002:a17:902:6b46:b029:ee:f84e:8655 with SMTP id g6-20020a1709026b46b02900eef84e8655mr12850943plt.76.1620429873028; Fri, 07 May 2021 16:24:33 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id o5sm5581119pgq.58.2021.05.07.16.24.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 May 2021 16:24:32 -0700 (PDT) Subject: Re: [PATCH v2] This makes it easier to figure out whether a particular instruction was actually translated. To: Nathan Ringo , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: From: Richard Henderson Message-ID: Date: Fri, 7 May 2021 16:24:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/7/21 3:48 PM, Nathan Ringo wrote: > - trace_translate_block(tb, tb->pc, tb->tc.ptr); > + trace_translate_block(tb, tb->pc, (int)tb->icount, tb->tc.ptr); What target are you looking at, because for the variable-length isa's, instruction count may not really help. Perhaps tb->size instead? r~