From: Laszlo Ersek <lersek@redhat.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"qemu devel list" <qemu-devel@nongnu.org>,
"Ani Sinha" <ani@anisinha.ca>, "Ard Biesheuvel" <ardb@kernel.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-stable@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Oliver Steffen" <osteffen@redhat.com>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Dann Frazier" <dann.frazier@canonical.com>
Subject: Re: [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block
Date: Thu, 2 Mar 2023 11:38:48 +0100 [thread overview]
Message-ID: <f3ea947e-aa33-f627-25e9-6eed3e2d8b7a@redhat.com> (raw)
In-Reply-To: <CAATJJ0LoQW9RDF=1=f_D1zWJSgWzMMtJ0FvqdsQYd9zOuuKkgg@mail.gmail.com>
On 3/2/23 09:32, Christian Ehrhardt wrote:
> good ~instant
> [08:14:37.267336194] Select Item: 0xE
> [08:14:37.268346995] [Bds]RegisterKeyNotify: 000C/0000 80000000/00 Success
>
> bad ~8s
> [08:15:43.561054490] Select Item: 0xE
> [08:15:51.291039364] [Bds]RegisterKeyNotify: 000C/0000 80000000/00 Success
Yes, this is consistent with my hypothesis.
PlatformBootManagerBeforeConsole()
GetFrontPageTimeoutFromQemu()
QemuFwCfgSelectItem (QemuFwCfgItemBootMenu)
// "Select Item: 0xE"
gRT->SetVariable()
PlatformRegisterOptionsAndKeys()
EfiBootManagerAddKeyOptionVariable()
gRT->SetVariable()
BmProcessKeyOption()
BmRegisterHotkeyNotify()
// "[Bds]RegisterKeyNotify: 000C/0000 80000000/00 Success"
IOW, there are at least two gRT->SetVariable() calls in OVMF (with
EFI_VARIABLE_NON_VOLATILE attribute) between the two adjacent log lines
you quoted.
The other functions listed in the call tree may contain further
gRT->SetVariable() calls.
Laszlo
next prev parent reply other threads:[~2023-03-02 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:01 [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block Laszlo Ersek
2023-01-04 9:33 ` Ard Biesheuvel
2023-01-04 10:26 ` Laszlo Ersek
2023-01-04 9:34 ` Philippe Mathieu-Daudé
2023-01-04 10:29 ` Laszlo Ersek
2023-01-04 10:38 ` Igor Mammedov
2023-01-04 12:27 ` Philippe Mathieu-Daudé
2023-01-04 10:35 ` Igor Mammedov
2023-01-04 12:13 ` Laszlo Ersek
2023-01-04 12:35 ` Michael S. Tsirkin
2023-01-05 7:13 ` Laszlo Ersek
2023-01-05 9:00 ` Philippe Mathieu-Daudé
2023-01-05 9:51 ` Michael S. Tsirkin
2023-03-01 7:17 ` Christian Ehrhardt
2023-03-01 8:03 ` Laszlo Ersek
2023-03-02 8:32 ` Christian Ehrhardt
2023-03-02 10:38 ` Laszlo Ersek [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-05 16:18 Laszlo Ersek
2023-01-05 16:21 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ea947e-aa33-f627-25e9-6eed3e2d8b7a@redhat.com \
--to=lersek@redhat.com \
--cc=ani@anisinha.ca \
--cc=ardb@kernel.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dann.frazier@canonical.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=osteffen@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=ppolawsk@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).